-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Ensure typescript dto file is valid before continuing #17865
Conversation
❌ E2E Happy path tests failed ❗ See Details
Tested with Eclipse Che Multiuser User on K8S (minikube v1.1.1) ℹ️ |
It's still strange as with -e/-u flag of script, build script should exit in case of error Change-Id: I9314ef7d8df68927d4a710cef8e9366d3582d83d Signed-off-by: Florent Benoit <fbenoit@redhat.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM if:
- we don't care that the happy path failed or,
- after rebasing the happy path passes.
Reviewers, please comment how you tested the PR when approving it.
I did no testing at all, just read the PR. :D
❌ E2E Happy path tests failed ❗ See Details
Tested with Eclipse Che Multiuser User on K8S (minikube v1.1.1) ℹ️ |
of happy path is not related |
What does this PR do?
Ensure typescript dto file is valid before continuing
also fix shellcheck errors
Screenshot/screencast of this PR
N/A
What issues does this PR fix or reference?
#17861
How to test this PR?
run the build.script by changing dto-pom.xml with invalid content
PR Checklist
As the author of this Pull Request I made sure that:
What issues does this PR fix or reference
andHow to test this PR
completedReviewers
Reviewers, please comment how you tested the PR when approving it.