Allow copying also the content of the config map #18264
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: David Festal <dfestal@redhat.com>
davidfestal
requested review from
amisevsk,
metlos,
nickboldt and
sleshchenko
as code owners
che-bot
added
target/branch
mshaposhnik
reviewed
Nov 3, 2020
...eclipse/che/workspace/infrastructure/openshift/provision/Openshift4TrustedCAProvisioner.java
Outdated
Show resolved
Hide resolved
mshaposhnik
reviewed
Nov 3, 2020
...eclipse/che/workspace/infrastructure/openshift/provision/Openshift4TrustedCAProvisioner.java
Outdated
Show resolved
Hide resolved
mshaposhnik
approved these changes
Nov 3, 2020
Signed-off-by: David Festal <dfestal@redhat.com>
as requested by @mshaposhnik Signed-off-by: David Festal <dfestal@redhat.com>
Signed-off-by: David Festal <dfestal@redhat.com>
che-bot
removed
the
status/code-review
|
@mshaposhnik @skabashnyuk This PR should probably be cherry-picked to the Is this something platform team plan to integrate into next Sprint ? cc @l0rd |
22 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: David Festal dfestal@redhat.com
What does this PR do?
This PR allows correctly propagating up to the workspace, the content of the trusted CA bundle configured
What issues does this PR fix or reference?
#18245
How to test this PR?
my-ca-certsconfig map with 1 key namemy.crtand an untrusted certificate as valuespec.server.ServerTrustStoreConfigMapNameof theCheClustercustom resource to the name of themy-ca-certsconfig mapca-certsconfig map that contains aca-bundle.crtkey (with OpenShift-injected certificates) and themy.crtkey with your untrusted certificate as a value.PR Checklist
As the author of this Pull Request I made sure that:
What issues does this PR fix or referenceandHow to test this PRcompletedReviewers
Reviewers, please comment how you tested the PR when approving it.