Propagate CA certs bundle on all infrastructures #18377

mmorhun · 2020-11-16T08:34:19Z

Signed-off-by: Mykola Morhun mmorhun@redhat.com

What does this PR do?

Propagates CA bundle into user's workspaces on all infrastructures.

What issues does this PR fix or reference?

How to test this PR?

Deploy Che on a Kubernetes family infrastructure
Create a config map with CA certificates in che namespace
Add the config map into CR:

spec:
  server:
    serverTrustStoreConfigMapName: custom-ca

Start a workspace, check that /public-certs has the certificate in it.

PR Checklist

As the author of this Pull Request I made sure that:

Reviewers

Reviewers, please comment how you tested the PR when approving it.

che-bot · 2020-11-16T08:52:03Z

❌ E2E Happy path tests failed ❗

See Details

Jenkins job
test report
logs and configs
Happy path tests DevFile
image: maxura/che-server:18377

Tested with Eclipse Che Multiuser User on K8S (minikube v1.1.1)

Use comment "[crw-ci-test]" to rerun happy path E2E test.
Use comment "[crw-ci-test --rebuild]" to re-build the images and rerun happy path E2E test.

...clipse/che/workspace/infrastructure/kubernetes/provision/KubernetesTrustedCAProvisioner.java

che-bot · 2020-11-16T13:26:20Z

✅ E2E Happy path tests succeed 🎉

See Details

Jenkins job
logs and configs
Happy path tests DevFile
image: maxura/che-server:18377

Tested with Eclipse Che Multiuser User on K8S (minikube v1.1.1)

Use comment "[crw-ci-test]" to rerun happy path E2E test.
Use comment "[crw-ci-test --rebuild]" to re-build the images and rerun happy path E2E test.

skabashnyuk · 2020-11-16T14:43:06Z

...java/org/eclipse/che/workspace/infrastructure/kubernetes/provision/TrustedCAProvisioner.java

+import org.eclipse.che.workspace.infrastructure.kubernetes.namespace.KubernetesNamespace;
+
+/** Provisions trusted CA certificate into Che server components and all workspaces pods. */
+public interface TrustedCAProvisioner {


is it possible to implement as ConfigurationProvisioner ?

Yes, it is. Will do that.

...java/org/eclipse/che/workspace/infrastructure/kubernetes/provision/TrustedCAProvisioner.java

che-bot · 2020-11-19T12:31:59Z

✅ E2E Happy path tests succeed 🎉

See Details

Jenkins job
logs and configs
Happy path tests DevFile
image: maxura/che-server:18377

Tested with Eclipse Che Multiuser User on K8S (minikube v1.1.1)

Use comment "[crw-ci-test]" to rerun happy path E2E test.
Use comment "[crw-ci-test --rebuild]" to re-build the images and rerun happy path E2E test.

che-bot · 2020-11-19T14:28:55Z

❌ E2E Happy path tests failed ❗

See Details

Jenkins job
test report
logs and configs
Happy path tests DevFile
image: maxura/che-server:18377

Tested with Eclipse Che Multiuser User on K8S (minikube v1.1.1)

Use comment "[crw-ci-test]" to rerun happy path E2E test.
Use comment "[crw-ci-test --rebuild]" to re-build the images and rerun happy path E2E test.

mmorhun · 2020-11-19T15:46:07Z

[crw-ci-test --rebuild]

che-bot · 2020-11-19T16:02:59Z

✅ E2E Happy path tests succeed 🎉

See Details

Jenkins job
logs and configs
Happy path tests DevFile
image: maxura/che-server:18377

Tested with Eclipse Che Multiuser User on K8S (minikube v1.1.1)

Use comment "[crw-ci-test]" to rerun happy path E2E test.
Use comment "[crw-ci-test --rebuild]" to re-build the images and rerun happy path E2E test.

dockerfiles/keycloak/kc_realm_user.sh

che-bot · 2020-11-23T15:20:30Z

✅ E2E Happy path tests succeed 🎉

See Details

Jenkins job
logs and configs
Happy path tests DevFile
image: maxura/che-server:18377

Tested with Eclipse Che Multiuser User on K8S (minikube v1.1.1)

Use comment "[crw-ci-test]" to rerun happy path E2E test.
Use comment "[crw-ci-test --rebuild]" to re-build the images and rerun happy path E2E test.

che-bot · 2020-11-25T09:48:38Z

❌ E2E Happy path tests failed ❗

See Details

Jenkins job
test report
logs and configs
Happy path tests DevFile
image: maxura/che-server:18377

Tested with Eclipse Che Multiuser User on K8S (minikube v1.1.1)

Use comment "[crw-ci-test]" to rerun happy path E2E test.
Use comment "[crw-ci-test --rebuild]" to re-build the images and rerun happy path E2E test.

assembly/assembly-wsmaster-war/src/main/webapp/WEB-INF/classes/che/che.properties

.../eclipse/che/workspace/infrastructure/openshift/provision/OpenshiftTrustedCAProvisioner.java

assembly/assembly-wsmaster-war/src/main/webapp/WEB-INF/classes/che/che.properties

che-bot · 2020-11-25T10:27:01Z

❌ E2E Happy path tests failed ❗

See Details

Jenkins job
test report
logs and configs
Happy path tests DevFile
image: maxura/che-server:18377

Tested with Eclipse Che Multiuser User on K8S (minikube v1.1.1)

Use comment "[crw-ci-test]" to rerun happy path E2E test.
Use comment "[crw-ci-test --rebuild]" to re-build the images and rerun happy path E2E test.

mmorhun · 2020-11-25T11:33:18Z

[crw-ci-test --rebuild]

che-bot · 2020-11-25T11:44:09Z

❌ E2E Happy path tests failed ❗

See Details

Jenkins job
test report
logs and configs
Happy path tests DevFile
image: maxura/che-server:18377

Tested with Eclipse Che Multiuser User on K8S (minikube v1.1.1)

Use comment "[crw-ci-test]" to rerun happy path E2E test.
Use comment "[crw-ci-test --rebuild]" to re-build the images and rerun happy path E2E test.

che-bot · 2020-11-25T12:01:54Z

❌ E2E Happy path tests failed ❗

See Details

Jenkins job
test report
logs and configs
Happy path tests DevFile
image: maxura/che-server:18377

Tested with Eclipse Che Multiuser User on K8S (minikube v1.1.1)

Use comment "[crw-ci-test]" to rerun happy path E2E test.
Use comment "[crw-ci-test --rebuild]" to re-build the images and rerun happy path E2E test.

che-bot · 2020-11-25T12:51:57Z

❌ E2E Happy path tests failed ❗

See Details

Jenkins job
test report
logs and configs
Happy path tests DevFile
image: maxura/che-server:18377

Tested with Eclipse Che Multiuser User on K8S (minikube v1.1.1)

Use comment "[crw-ci-test]" to rerun happy path E2E test.
Use comment "[crw-ci-test --rebuild]" to re-build the images and rerun happy path E2E test.

mmorhun · 2020-11-25T12:57:25Z

[crw-ci-test --rebuild]

che-bot · 2020-11-25T13:02:24Z

❌ E2E Happy path tests failed ❗

See Details

Jenkins job
test report
logs and configs
Happy path tests DevFile
image: maxura/che-server:18377

Tested with Eclipse Che Multiuser User on K8S (minikube v1.1.1)

Use comment "[crw-ci-test]" to rerun happy path E2E test.
Use comment "[crw-ci-test --rebuild]" to re-build the images and rerun happy path E2E test.

mmorhun · 2020-11-26T07:55:56Z

Rebased to get test fix from #18461

che-bot · 2020-11-26T08:38:40Z

❌ E2E Happy path tests failed ❗

See Details

Jenkins job
test report
logs and configs
Happy path tests DevFile
image: maxura/che-server:18377

Tested with Eclipse Che Multiuser User on K8S (minikube v1.1.1)

Use comment "[crw-ci-test]" to rerun happy path E2E test.
Use comment "[crw-ci-test --rebuild]" to re-build the images and rerun happy path E2E test.

mmorhun · 2020-11-26T09:15:07Z

[crw-ci-test --rebuild]

che-bot · 2020-11-26T09:44:36Z

❌ E2E Happy path tests failed ❗

See Details

Jenkins job
test report
logs and configs
Happy path tests DevFile
image: maxura/che-server:18377

Tested with Eclipse Che Multiuser User on K8S (minikube v1.1.1)

Use comment "[crw-ci-test]" to rerun happy path E2E test.
Use comment "[crw-ci-test --rebuild]" to re-build the images and rerun happy path E2E test.

dmytro-ndp · 2020-11-26T10:16:23Z

@mmorhun: FYI: Happy path PR check has failed because of known issue #18034, which is not related to PR changes.

Signed-off-by: Mykola Morhun <mmorhun@redhat.com>

che-bot · 2020-11-27T07:25:05Z

❌ E2E Happy path tests failed ❗

See Details

Jenkins job
test report
logs and configs
Happy path tests DevFile
image: maxura/che-server:18377

Tested with Eclipse Che Multiuser User on K8S (minikube v1.1.1)

Use comment "[crw-ci-test]" to rerun happy path E2E test.
Use comment "[crw-ci-test --rebuild]" to re-build the images and rerun happy path E2E test.

mmorhun requested review from sparkoo, skabashnyuk, mshaposhnik and sleshchenko November 16, 2020 08:34

mmorhun requested review from amisevsk, ibuziuk, metlos and nickboldt as code owners November 16, 2020 08:34

mmorhun self-assigned this Nov 16, 2020

che-bot added status/code-review This issue has a pull request posted for it and is awaiting code review completion by the community. kind/enhancement A feature request - must adhere to the feature request template. labels Nov 16, 2020

tolusha mentioned this pull request Nov 16, 2020

Che Deploy Sprint #193 #18375

Closed

58 tasks

tolusha reviewed Nov 16, 2020

View reviewed changes

...clipse/che/workspace/infrastructure/kubernetes/provision/KubernetesTrustedCAProvisioner.java Show resolved Hide resolved

mshaposhnik approved these changes Nov 16, 2020

View reviewed changes

skabashnyuk reviewed Nov 16, 2020

View reviewed changes

...java/org/eclipse/che/workspace/infrastructure/kubernetes/provision/TrustedCAProvisioner.java Outdated Show resolved Hide resolved

mmorhun force-pushed the che-17634 branch from ffea822 to 20d40ed Compare November 19, 2020 12:12

mmorhun requested a review from benoitf as a code owner November 19, 2020 12:12

mmorhun requested a review from mshaposhnik November 19, 2020 12:13

mmorhun force-pushed the che-17634 branch from 20d40ed to f64d6c0 Compare November 19, 2020 14:19

eclipse-che deleted a comment from che-bot Nov 19, 2020

skabashnyuk reviewed Nov 20, 2020

View reviewed changes

dockerfiles/keycloak/kc_realm_user.sh Show resolved Hide resolved

tolusha approved these changes Nov 24, 2020

View reviewed changes

sleshchenko reviewed Nov 25, 2020

View reviewed changes

mmorhun force-pushed the che-17634 branch from ceb42bb to 58136bb Compare November 25, 2020 10:14

sleshchenko approved these changes Nov 25, 2020

View reviewed changes

mmorhun force-pushed the che-17634 branch from b660de8 to 9504c20 Compare November 26, 2020 07:51

mmorhun added 8 commits November 27, 2020 09:20

Implement CA bundle propagation on Kubernetes infrastructures family

072f688

Signed-off-by: Mykola Morhun <mmorhun@redhat.com>

tmp

edc6d17

Signed-off-by: Mykola Morhun <mmorhun@redhat.com>

Move CA bundle propagation into a provisioner

8c2d0fc

Signed-off-by: Mykola Morhun <mmorhun@redhat.com>

Fix comment

62d8fb5

Signed-off-by: Mykola Morhun <mmorhun@redhat.com>

Rename properties

f24aec3

Signed-off-by: Mykola Morhun <mmorhun@redhat.com>

Update property name in inject

6515aea

Signed-off-by: Mykola Morhun <mmorhun@redhat.com>

Correctly handle empty labels string

8df076c

Signed-off-by: Mykola Morhun <mmorhun@redhat.com>

Fix formatting

187bb72

Signed-off-by: Mykola Morhun <mmorhun@redhat.com>

mmorhun force-pushed the che-17634 branch from 9504c20 to 187bb72 Compare November 27, 2020 07:20

mmorhun merged commit 75889e8 into master Nov 27, 2020

mmorhun deleted the che-17634 branch November 27, 2020 13:02

che-bot removed the status/code-review This issue has a pull request posted for it and is awaiting code review completion by the community. label Nov 27, 2020

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Propagate CA certs bundle on all infrastructures #18377

Propagate CA certs bundle on all infrastructures #18377

mmorhun commented Nov 16, 2020

che-bot commented Nov 16, 2020

che-bot commented Nov 16, 2020

skabashnyuk Nov 16, 2020

mmorhun Nov 19, 2020

che-bot commented Nov 19, 2020

che-bot commented Nov 19, 2020

mmorhun commented Nov 19, 2020

che-bot commented Nov 19, 2020

che-bot commented Nov 23, 2020

che-bot commented Nov 25, 2020

che-bot commented Nov 25, 2020

mmorhun commented Nov 25, 2020

che-bot commented Nov 25, 2020

che-bot commented Nov 25, 2020

che-bot commented Nov 25, 2020

mmorhun commented Nov 25, 2020

che-bot commented Nov 25, 2020

mmorhun commented Nov 26, 2020

che-bot commented Nov 26, 2020

mmorhun commented Nov 26, 2020

che-bot commented Nov 26, 2020

dmytro-ndp commented Nov 26, 2020 •

edited

Loading

che-bot commented Nov 27, 2020

Propagate CA certs bundle on all infrastructures #18377

Propagate CA certs bundle on all infrastructures #18377

Conversation

mmorhun commented Nov 16, 2020

What does this PR do?

What issues does this PR fix or reference?

How to test this PR?

PR Checklist

Reviewers

che-bot commented Nov 16, 2020

che-bot commented Nov 16, 2020

skabashnyuk Nov 16, 2020

Choose a reason for hiding this comment

mmorhun Nov 19, 2020

Choose a reason for hiding this comment

che-bot commented Nov 19, 2020

che-bot commented Nov 19, 2020

mmorhun commented Nov 19, 2020

che-bot commented Nov 19, 2020

che-bot commented Nov 23, 2020

che-bot commented Nov 25, 2020

che-bot commented Nov 25, 2020

mmorhun commented Nov 25, 2020

che-bot commented Nov 25, 2020

che-bot commented Nov 25, 2020

che-bot commented Nov 25, 2020

mmorhun commented Nov 25, 2020

che-bot commented Nov 25, 2020

mmorhun commented Nov 26, 2020

che-bot commented Nov 26, 2020

mmorhun commented Nov 26, 2020

che-bot commented Nov 26, 2020

dmytro-ndp commented Nov 26, 2020 • edited Loading

che-bot commented Nov 27, 2020

dmytro-ndp commented Nov 26, 2020 •

edited

Loading