Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix external helm charts links #18651

Merged
merged 1 commit into from
Dec 18, 2020
Merged

Fix external helm charts links #18651

merged 1 commit into from
Dec 18, 2020

Conversation

mmorhun
Copy link
Contributor

@mmorhun mmorhun commented Dec 18, 2020

Signed-off-by: Mykola Morhun mmorhun@redhat.com

What does this PR do?

Corrects broken links to prometheus and grafana external helm carts.

Screenshot/screencast of this PR

N/A

What issues does this PR fix or reference?

#18648

How to test this PR?

Deploy Eclipse Che using helm installer:
chectl server:deploy --installer=helm --platform=<platform>

PR Checklist

As the author of this Pull Request I made sure that:

Reviewers

Reviewers, please comment how you tested the PR when approving it.

Signed-off-by: Mykola Morhun <mmorhun@redhat.com>
@che-bot che-bot added status/code-review This issue has a pull request posted for it and is awaiting code review completion by the community. kind/bug Outline of a bug - must adhere to the bug report template. labels Dec 18, 2020
@sonarcloud
Copy link

sonarcloud bot commented Dec 18, 2020

Kudos, SonarCloud Quality Gate passed!

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@che-bot
Copy link
Contributor

che-bot commented Dec 18, 2020

❌ E2E Happy path tests failed ❗

See Details

Tested with Eclipse Che Multiuser User on K8S (minikube v1.1.1)

  • Use comment "[crw-ci-test]" to rerun happy path E2E test.
  • Use comment "[crw-ci-test --rebuild]" to re-build the images and rerun happy path E2E test.

@tolusha tolusha mentioned this pull request Dec 18, 2020
56 tasks
@mmorhun mmorhun changed the title Fix external charts links Fix external helm charts links Dec 18, 2020
@mmorhun mmorhun merged commit 08868bf into master Dec 18, 2020
@mmorhun mmorhun deleted the che-18648 branch December 18, 2020 12:05
@che-bot che-bot removed the status/code-review This issue has a pull request posted for it and is awaiting code review completion by the community. label Dec 18, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/bug Outline of a bug - must adhere to the bug report template.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants