Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change cert-manager api version #19075

Merged
merged 1 commit into from
Feb 22, 2021
Merged

Change cert-manager api version #19075

merged 1 commit into from
Feb 22, 2021

Conversation

flacatus
Copy link
Contributor

@flacatus flacatus commented Feb 16, 2021

Signed-off-by: Flavius Lacatusu flacatus@redhat.com

What does this PR do?

Change cert-manager api version to v1 to make compatible devworkspace and helm in kubernetes platform

Reff issue: #18962

Screenshot/screencast of this PR

What issues does this PR fix or reference?

How to test this PR?

PR Checklist

As the author of this Pull Request I made sure that:

Reviewers

Reviewers, please comment how you tested the PR when approving it.

Signed-off-by: Flavius Lacatusu <flacatus@redhat.com>
@che-bot che-bot added status/code-review This issue has a pull request posted for it and is awaiting code review completion by the community. kind/enhancement A feature request - must adhere to the feature request template. labels Feb 16, 2021
@tolusha tolusha mentioned this pull request Feb 16, 2021
57 tasks
@che-bot
Copy link
Contributor

che-bot commented Feb 16, 2021

✅ E2E Happy path tests succeed 🎉

See Details

Tested with Eclipse Che Multiuser User on K8S (minikube v1.1.1)

  • Use comment "[crw-ci-test]" to rerun happy path E2E test.
  • Use comment "[crw-ci-test --rebuild]" to re-build the images and rerun happy path E2E test.

@flacatus flacatus merged commit 45f4f6c into master Feb 22, 2021
@flacatus flacatus deleted the certtempl branch February 22, 2021 13:28
@che-bot che-bot removed the status/code-review This issue has a pull request posted for it and is awaiting code review completion by the community. label Feb 22, 2021
@che-bot che-bot added this to the 7.27 milestone Feb 22, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/enhancement A feature request - must adhere to the feature request template.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants