Add variability for test suite to load tests #19343
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Katka92
requested review from
benoitf,
musienko-maxim,
nickboldt,
Ohrimenko1988,
rhopp and
sparkoo
as code owners
che-bot
added
status/code-review
|
❌ E2E Happy path tests failed ❗ See Details
Tested with Eclipse Che Multiuser User on K8S (minikube v1.1.1)
|
|
[crw-ci-test --rebuild] |
|
❌ E2E Happy path tests failed ❗ See Details
Tested with Eclipse Che Multiuser User on K8S (minikube v1.1.1)
|
dmytro-ndp
reviewed
Mar 19, 2021
| @@ -59,14 +63,16 @@ spec: | |||
| value: "1000000" | |||
| - name: TS_SELENIUM_WORKSPACE_STATUS_POLLING | |||
| value: "500000" | |||
| - name: TS_LOAD_TESTS | |||
There was a problem hiding this comment.
What is the benefit of adding one more constant to support if we continue using TEST_SUITE = "load-test" ?
|
✅ E2E Happy path tests succeed 🎉 See Details
Tested with Eclipse Che Multiuser User on K8S (minikube v1.1.1)
|
dmytro-ndp
approved these changes
Mar 22, 2021
che-bot
removed
the
status/code-review
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
The load tests would be able to execute not only load-test test suite but also any other common test suite already written in e2e repo.
What issues does this PR fix or reference?
Extending load tests suite.
How to test this PR?
Run load tests with
load-testorJavaMavenEaptest suite.PR Checklist
As the author of this Pull Request I made sure that:
What issues does this PR fix or referenceandHow to test this PRcompletedReviewers
Reviewers, please comment how you tested the PR when approving it.