Improving flow when user denies Bitbucket access to Che #19620
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: xbaran4 <pbaran@redhat.com>
|
Can one of the admins verify this patch? |
che-bot
added
status/code-review
Signed-off-by: xbaran4 <pbaran@redhat.com>
Signed-off-by: xbaran4 <pbaran@redhat.com>
|
what about unit tests? |
|
Please merge the latest master to fix the build check. |
Signed-off-by: xbaran4 <pbaran@redhat.com>
skabashnyuk
reviewed
Apr 27, 2021
...-core-api-auth/src/main/java/org/eclipse/che/security/oauth1/OAuthAuthenticationService.java
Show resolved
Hide resolved
|
If there are not any apparent issues, I believe this PR can be merged in order to help with dashboard reaction implementation. I will provide tests for OAuthAuthenticationService in a subsequent PR. Testing this PR is described above. It was also tested by me in the current state. |
skabashnyuk
approved these changes
Apr 28, 2021
sparkoo
approved these changes
Apr 28, 2021
che-bot
removed
the
status/code-review
9 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: xbaran4 pbaran@redhat.com
What does this PR do?
After user denies authorization of che with bitbucket they are redirected to redirect_after_login URI with error query parameter.
Screenshot/screencast of this PR
What issues does this PR fix or reference?
Improve workflow when user denies Bitbucket access for Che #19274
How to test this PR?
https://www.eclipse.org/che/docs/che-7/administration-guide/configuring-authorization/#proc_configuring-bitbucket-server-oauth1_che)
PR Checklist
As the author of this Pull Request I made sure that:
What issues does this PR fix or referenceandHow to test this PRcompletedReviewers
Reviewers, please comment how you tested the PR when approving it.