Add Petclinic+MySQL stack, petclinic mysql sample project. Fix dashbo… #2376
Conversation
|
Build # 337 - FAILED Please check console output at https://ci.codenvycorp.com/job/che-pullrequests-build/337/ to view the results. |
|
ci-build |
|
Build success. https://ci.codenvycorp.com/job/che-pullrequests-build/338/ |
|
@slemeur @TylerJewell the new stack and template is there. I placed it on #1 position |
|
@slemeur the first one means the default in UD. |
TylerJewell
added
the
kind/enhancement
|
@eivantsov - do you have a milestone that you really want this in? ie, are you hoping it is M1 or can it wait until M2? Your answer will influence how aggressive I try to get in evaluating this sooner vs. later. This is exciting to see. |
| "tags": [ | ||
| "Java 1.8, Tomcat 8, MySQL 5.7" | ||
| ], | ||
| "components": [ |
There was a problem hiding this comment.
One of the suggestions that I made to Stevan was that we should probably be more complete on the list of components that we have and their versions. We should list all of the libraries that we are installing into the Ubuntu system - so bash, openssl, etc. Anything that we are explicitly installing with a RUN command should probably be added here.
We also need the mysql reference, and I think the JDK / maven versions are out of date?
There was a problem hiding this comment.
These are tags, smth that will show up in user dashboard. We use tags to match stacks and samples.
So, if I like versions of everything, we just do not have space in the stack box on UD.
Also, this will break all the filtering.
This is a UD issue. Perhaps, we should use components to display in UD but use tags that can be super unique but not super readable to match samples.
@ashumilova can comment - we talked about it.
There was a problem hiding this comment.
@eivantsov - I think there is a difference between components and tags in this document. The tags are used for filtering and they are a different list of labels. But I believe the components are the list that appears in the UD.
If we have a long list of components, are we concerned about the display height of the stack boxes? @ashumilova - if we have a super long list of components, do we just cut off the list or do we make the box taller? We probably need to think about what to do here.
But I would think that we should go ahead and make the components list complete and then as a secondary measure work on improving the UX display of the stack box?
There was a problem hiding this comment.
@TylerJewell Tag appear in UI and they are used to match stacks and filters. Components aren't used at all now in master.
This is a broader question and does not affect this PR only. This is how things work now, you may check with @ashumilova if you have doubts.
|
@TylerJewell I do not have any preferences on when this should be released. |
| } | ||
| }, | ||
| "recipe": { | ||
| "content": "services:\n db:\n image: codenvy/mysql\n environment:\n MYSQL_DATABASE: petclinic\n MYSQL_USER: petclinic\n MYSQL_PASSWORD: password\n mem_limit: 2147483648\n dev-machine:\n image: codenvy/ubuntu_jdk8\n mem_limit: 2147483648\n depends_on:\n - db\n links:\n - db", |
There was a problem hiding this comment.
Why you used both depends_on and links?
|
Build success. https://ci.codenvycorp.com/job/che-pullrequests-build/341/ |
|
We can change the name of the dev-machine, how to name it in stacks? |
|
@ashumilova : Yes agree. it is planned for the advanced stack form #2316 |
|
Build # 349 - FAILED Please check console output at https://ci.codenvycorp.com/job/che-pullrequests-build/349/ to view the results. |
|
ci-build |
|
Build success. https://ci.codenvycorp.com/job/che-pullrequests-build/351/ |
|
I do not have a great alternative for dev-machine. But it always feels like a little bit of a robot to me whenever i see that appear in our product: "i-am-a-dev-machine," said the metalic robot as he violently waves his robotic arms up and down wishing he had opposable thumbs. |
|
@TylerJewell all your questions are general questions to how things work in stacks and templates for UD. What should I do with this PR? Everything you have mentioned is not going to be fixed in this PR. |
| "name": "build", | ||
| "type": "mvn", | ||
| "commandLine": "mvn -f ${current.project.path} clean install -DskipTests", | ||
| "attributes": { |
There was a problem hiding this comment.
Can you check this macro with M1 - according to what Vlad produced, this macro is now in a different format. Should we update it?
|
Just need to respond to my comment on components from this evening, and then take a look at the thought on changing the macro to the updated names. |
…e mappings Signed-off-by: Eugene Ivantsov <eivantsov@codenvy.com>
ghost
force-pushed
the
multi_machine_sample_and_fixes
branch
from
1b83d09
to
b732aa8
Compare
|
Build # 378 - FAILED Please check console output at https://ci.codenvycorp.com/job/che-pullrequests-build/378/ to view the results. |
|
ci-build |
|
Build # 379 - FAILED Please check console output at https://ci.codenvycorp.com/job/che-pullrequests-build/379/ to view the results. |
…_and_fixes Add Petclinic+MySQL stack, petclinic mysql sample project. Fix dashbo…
Add Petclinic+MySQL stack, petclinic mysql sample project. Fix dashbo…
What does this PR do?
This PR adds a new stack with a sample app - Petclinic + MySQL in 2 containers
What issues does this PR fix or reference?
#2290
#2291
Previous behavior
(Remove this section if not relevant)
New behavior
A new stack is a demo of the new compose syntax.
PR type
Signed-off-by: Eugene Ivantsov eivantsov@codenvy.com