Add CentOS based nodejs4 stack to default assembly #4788
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Can one of the admins verify this patch? |
l0rd
requested changes
Apr 13, 2017
| } | ||
| }, | ||
| "recipe": { | ||
| "location": "dharmit/centos-nodejs", |
There was a problem hiding this comment.
Don't you want to use registry.centos registry here?
dharmit
force-pushed
the
centos-nodejs
branch
2 times, most recently
from
95836ea
to
bcaff88
Compare
l0rd
requested changes
Apr 18, 2017
| } | ||
| }, | ||
| { | ||
| "id": "CentOS nodejs", |
There was a problem hiding this comment.
All stacks, except centos nodejs and wildfly swarm have lowercase IDs without spaces. Can you please change the IDs into:
- nodejs4
- wildfly-swarm
|
@l0rd thanks for pointing that out. I updated the PR. Let me know if it looks good or needs further modification. |
Signed-off-by: Dharmit Shah <dshah@redhat.com>
l0rd
approved these changes
Apr 20, 2017
slemeur
approved these changes
Jun 16, 2017
slemeur
added
the
kind/enhancement
JPinkney
pushed a commit
to JPinkney/che
that referenced
this pull request
Aug 17, 2017
Signed-off-by: Dharmit Shah <dshah@redhat.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Dharmit Shah dshah@redhat.com
What does this PR do?
Add NodeJS stack based on CentOS to the default assembly
Changelog
Add CentOS based nodejs4 stack to default assembly
Release Notes
Add CentOS based nodejs4 stack to default assembly
Docs PR
cc @l0rd