CHE-4689: improve dockerfile parser #4881
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Oleksii Kurinnyi <okurinnyi@codenvy.com>
akurinnoy
added
the
kind/bug
benoitf
approved these changes
Apr 22, 2017
|
Build success. https://ci.codenvycorp.com/job/che-pullrequests-build/2486/ |
ashumilova
approved these changes
Apr 24, 2017
olexii4
approved these changes
Apr 24, 2017
ashumilova
approved these changes
Apr 24, 2017
|
Build success. https://ci.codenvycorp.com/job/che-pullrequests-build/2495/ |
JPinkney
pushed a commit
to JPinkney/che
that referenced
this pull request
Aug 17, 2017
* CHE-4689: improve dockerfile parser Signed-off-by: Oleksii Kurinnyi <okurinnyi@codenvy.com> * fixup! CHE-4689: improve dockerfile parser
skabashnyuk
pushed a commit
that referenced
this pull request
Jan 3, 2020
* CHE-4689: improve dockerfile parser Signed-off-by: Oleksii Kurinnyi <okurinnyi@codenvy.com> * fixup! CHE-4689: improve dockerfile parser
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
This PR fixes the bug when some dockerfile instructions which contain line breaks and ampersands were not parsed correctly.
What issues does this PR fix or reference?
#4689
Changelog
Fixed dockerfile parser in order to correctly parse instructions which contain line breaks and ampersands.
Release Notes
N/A - bugfix
Docs PR
N/A - bugfix
Signed-off-by: Oleksii Kurinnyi okurinnyi@codenvy.com