CHE-249: Setting workspace Pod terminationGracePeriodSeconds to zero #5007
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ibuziuk
added
the
target/branch
|
Can one of the admins verify this patch? |
amisevsk
requested changes
May 4, 2017
| @@ -1530,6 +1532,7 @@ private String waitAndRetrieveContainerID(String deploymentName) throws IOExcept | |||
| if (OPENSHIFT_POD_STATUS_RUNNING.equals(status)) { | |||
| String containerID = pod.getStatus().getContainerStatuses().get(0).getContainerID(); | |||
| String normalizedID = KubernetesStringUtils.normalizeContainerID(containerID); | |||
| pod.getSpec().setTerminationGracePeriodSeconds(OPENSHIFT_POD_TERMINATION_GRACE_PERIOD); | |||
There was a problem hiding this comment.
Doing it this way will not update the actual Pod spec. I think we need to add this in createOpenShiftDeployment()
PodSpec podSpec = new PodSpecBuilder()
.withContainers(container)
.withVolumes(getVolumesFrom(volumes, workspaceID))
.withTerminationGracePeriodSeconds(OPENSHIFT_POD_TERMINATION_GRACE_PERIOD)
.build();
|
@amisevsk oh, thank you for review - I had no chance to test this PR due to weird issue with building che (I even posted a question on stack overflow - http://stackoverflow.com/questions/43792427/maven-hangs-forever-during-the-project-build-used-to-work-fine) lemme update the PR |
Signed-off-by: Ilya Buziuk <ibuziuk@redhat.com>
|
PR has been updated |
|
Yes go ahead
Il 05 mag 2017 00:30, "Ilya Buziuk" <notifications@github.com> ha scritto:
… @l0rd <https://github.com/l0rd> @amisevsk <https://github.com/amisevsk>
shall we apply ? (code freeze is over I guess)
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#5007 (comment)>, or mute
the thread
<https://github.com/notifications/unsubscribe-auth/AAlC77CI8n0ELQNqtqg5Y_cRPxQBb0Xzks5r2lGOgaJpZM4NRJNF>
.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Setting workspace Pod terminationGracePeriodSeconds to zero
What issues does this PR fix or reference?
https://issues.jboss.org/browse/CHE-249