-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
CHE-4518: change styles for input boxes #5384
Conversation
ng-minlength="3" | ||
ng-maxlength="20" | ||
ng-pattern="/^[ A-Za-z0-9_\-\.]+$/"> | ||
<div ng-message="pattern">Factory name may contain digits, latin letters, spaces, _ , . , - and should start only with digits, latin letters or underscores</div> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You removed the ng-message =required . Does it need to be removed on all che-input-box elements in UD ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Both messages and an asterisk will be too much.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
so, is that ng-message="required" need to be removed on all occurence of che-input-box we have in all pages of UD ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes. But we have only three input boxes in che. And I have changed them.
We have many places with input box in codenvy. In general, we have three input widgets: che-input, che-input-box and che-textarea.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ah ok :) I thought we had more ^^
git-url | ||
required> | ||
<div ng-message="gitUrl" ng-if="createFactoryGitCtrl.location && createFactoryGitCtrl.location.length > 0"> | ||
<span>Invalid Git URL</span> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
the required field is there transformed as a span element, on the previous change it was deleted. Could you explain why in some case we need to remove it, or transform it to a span element. We couldn't keep the ng-message required element to be displayed ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I hide the error message in a case with required input (the same reason).
I will remove element for this message.
done |
Build success. https://ci.codenvycorp.com/job/che-pullrequests-build/2826/ |
Build success. https://ci.codenvycorp.com/job/che-pullrequests-build/2835/ |
Build success. https://ci.codenvycorp.com/job/che-pullrequests-build/2836/ |
Build success. https://ci.codenvycorp.com/job/che-pullrequests-build/2843/ |
Signed-off-by: Oleksii Orel <oorel@redhat.com>
Signed-off-by: Oleksii Orel <oorel@redhat.com>
Build success. https://ci.codenvycorp.com/job/che-pullrequests-build/2846/ |
Signed-off-by: Oleksii Orel oorel@redhat.com
What does this PR do?
Change styles for input boxes.
What issues does this PR fix or reference?
#4518
Changelog
Release Notes
On our road to Che 6, we have refined the input boxes in the Dashboard so that they look prettier and better to interact with. The different states of the input boxes are well defined and they allow the user to properly identify if the input is having the focus and is in edit mode. Similarly, it is now clearer to understand the mandatory fields and when the values are incorrect. As for the styles of the input boxes, they are simpler and easier to identify in the page.
Docs PR
N/A