Avoid NPE at using MutableProjectConfig #5869
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
RomanNikitenko
added
the
kind/bug
azatsarynnyy
reviewed
Aug 2, 2017
| @@ -55,7 +55,7 @@ public MutableProjectConfig() { | |||
|
|
|||
| @Override | |||
| public String getName() { | |||
| return name; | |||
| return name != null ? name : ""; | |||
There was a problem hiding this comment.
@RomanNikitenko just FYI - com.google.common.base.Strings#nullToEmpty
There was a problem hiding this comment.
@azatsarynnyy thank you, I've fixed it!
|
Build success. https://ci.codenvycorp.com/job/che-pullrequests-build/3245/ |
|
@azatsarynnyy @vparfonov I've changed checks for null: com.google.common.base.MoreObjects#firstNonNull instead of com.google.common.base.Strings#nullToEmpty because of in this case this one allows to avoid NPE for collections as well as for string or any object. |
azatsarynnyy
approved these changes
Aug 2, 2017
|
Build success. https://ci.codenvycorp.com/job/che-pullrequests-build/3247/ |
vparfonov
approved these changes
Aug 3, 2017
Signed-off-by: Roman Nikitenko <rnikiten@redhat.com>
RomanNikitenko
force-pushed
the
mutableProjectConfigFix
branch
from
ca84e96
to
35aebec
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
We have constructor for MutableProjectConfig without parameters here
and the fields are not initialized in this case.
These changes allow to avoid NPE in different places on client side where we use MutableProjectConfig
Changelog
Avoid NPE at using MutableProjectConfig
Signed-off-by: Roman Nikitenko rnikiten@redhat.com