Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Modify che-server Dockerfile to run on OpenShift #6200

Merged
merged 3 commits into from
Sep 11, 2017
Merged

Modify che-server Dockerfile to run on OpenShift #6200

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
98db39c
Modify che-server Dockerfile to run on OpenShift
l0rd Sep 8, 2017
1a0deb0
Fixup after Florent review
l0rd Sep 8, 2017
124f535
Fixup n.2 for newline
l0rd Sep 8, 2017
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions dockerfiles/che/Dockerfile
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -37,4 +37,7 @@ EXPOSE 8000 8080
COPY entrypoint.sh /entrypoint.sh
COPY open-jdk-source-file-location /open-jdk-source-file-location
ENTRYPOINT ["/entrypoint.sh"]
RUN mkdir /logs /data && \
chmod 0777 /logs /data
ADD eclipse-che.tar.gz /home/user/
RUN chmod -R 0777 /home/user
Copy link

@garagatyi garagatyi Sep 8, 2017 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we move it to the previous RUN instruction e.g.:

RUN mkdir -p /logs /data /home/user && \
    chmod -R 0777 /logs /data /home/user

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh, I see that it won't help because you want to affect unpacked archive

6 changes: 3 additions & 3 deletions dockerfiles/che/Dockerfile.centos
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -47,7 +47,7 @@ ENV LANG="C.UTF-8"
EXPOSE 8000 8080
COPY entrypoint.sh /entrypoint.sh
ENTRYPOINT ["/entrypoint.sh"]
RUN mkdir /logs /data && \
chmod 0777 /logs /data
ADD eclipse-che.tar.gz /home/user/
RUN mkdir /logs && chmod 0777 /logs
RUN chmod -R 0777 /home/user/
RUN mkdir /data && chmod 0777 /data
RUN chmod -R 0777 /home/user
2 changes: 1 addition & 1 deletion dockerfiles/cli/scripts/openshift/deploy_che.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -80,7 +80,7 @@ DEFAULT_COMMAND="deploy"
COMMAND=${COMMAND:-${DEFAULT_COMMAND}}
DEFAULT_CHE_IMAGE_REPO="docker.io/eclipse/che-server"
CHE_IMAGE_REPO=${CHE_IMAGE_REPO:-${DEFAULT_CHE_IMAGE_REPO}}
DEFAULT_CHE_IMAGE_TAG="nightly-centos"
DEFAULT_CHE_IMAGE_TAG="nightly"
CHE_IMAGE_TAG=${CHE_IMAGE_TAG:-${DEFAULT_CHE_IMAGE_TAG}}
DEFAULT_CHE_LOG_LEVEL="INFO"
CHE_LOG_LEVEL=${CHE_LOG_LEVEL:-${DEFAULT_CHE_LOG_LEVEL}}
Expand Down