make deploy script mac os friendly #6560
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
riuvshin
requested review from
ashumilova,
benoitf,
garagatyi,
tolusha and
vparfonov
as code owners
riuvshin
added
kind/task
skabashnyuk
approved these changes
Oct 3, 2017
benoitf
added
target/branch
|
Build success. https://ci.codenvycorp.com/job/che-pullrequests-build/3973/ |
|
@riuvshin why Mac Os friendly? And you are updating it here and not in master branch because you are supposed to merge it to master by the end of the week anyway right? |
garagatyi
reviewed
Oct 4, 2017
| sed "s| keycloak-oso-endpoint:.*| keycloak-oso-endpoint: ${KEYCLOAK_OSO_ENDPOINT}|" | \ | ||
| sed "s| keycloak-github-endpoint:.*| keycloak-github-endpoint: ${KEYCLOAK_GITHUB_ENDPOINT}|" | \ | ||
| sed "s/ keycloak-disabled:.*/ keycloak-disabled: \"${CHE_KEYCLOAK_DISABLED}\"/" | \ | ||
| if [ "${CHE_LOG_LEVEL}" == "DEBUG" ]; then sed "s/ log-level: \"INFO\"/ log-level: \"DEBUG\"/" ; else cat -; fi | \ | ||
| sed "$MULTI_USER_REPLACEMENT_STRING" | \ | ||
| if [ "${ENABLE_SSL}" == "false" ]; then sed "s/ che-openshift-secure-routes: \"true\"/ che-openshift-secure-routes: \"false\"/" ; else cat -; fi | \ | ||
| if [ "${ENABLE_SSL}" == "false" ]; then sed "s/ che-secure-external-urls: \"true\"/ che-secure-external-urls: \"false\"/" ; else cat -; fi | \ |
| # ---------------- | ||
| # helper functions | ||
| # ---------------- | ||
| append_after_match() { |
There was a problem hiding this comment.
Can you describe what it is used for in line comments
davidfestal
approved these changes
Oct 4, 2017
|
@l0rd there was used variation of |
|
agree with @davidfestal I will introduce separate PRs |
|
@davidfestal @l0rd here is sync PR to master #6566 once it will be merged I will update this PR |
riuvshin
changed the title
added 2 commits
October 4, 2017 15:56
|
@l0rd @davidfestal PR is updated :) |
davidfestal
approved these changes
Oct 4, 2017
benoitf
approved these changes
Oct 4, 2017
|
Build success. https://ci.codenvycorp.com/job/che-pullrequests-build/3990/ |
benoitf
removed
the
status/code-review
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
synchronize deploy script from rh-che, make it mac os friendly