Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Change locators in DasboardWorkspace page object #6723

Merged
merged 1 commit into from
Oct 13, 2017
Merged

Change locators in DasboardWorkspace page object #6723

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions ...-test/src/main/java/org/eclipse/che/selenium/pageobject/dashboard/DashboardWorkspace.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -99,7 +99,7 @@ private interface Locators {
"//div[contains(@class,'che-toolbar')]//span[contains(text(),'%s')]";
String WORKSPACES_LIST = "//ng-transclude[@class='che-list-content']";
String WORKSPACE_ITEM_NAME =
"//div[contains(@class, 'che-list-item-name')]/span[contains(text(),'%s')]";
"//div[contains(@class, 'workspace-name-clip')]//div[contains(@data-str, '%s')]";
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It may be reasonable to use debug-id here instead of xpath,

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It will be done by #6686.

String EXPORT_WORKSPACE_BTN =
"//button[contains(@class, 'che-button')]/span[text()='Export as a file']";
String DOWNLOAD_WORKSPACE_BTN = "//che-button-default[@che-button-title='download']";
Expand All @@ -116,7 +116,7 @@ private interface Locators {
String RUN_WORKSPACE_BTN = "//button/span[text()='Run']";
String STOP_WORKSPACE_BTN = "//button/span[contains(text(),'Stop')]";
String DELETE_WORKSPACE_BTN = "//button/span[text()='Delete']";
String STATE_WORKSPACE = "//span[contains(@class, '%s')]";
String STATE_WORKSPACE = "//div[contains(@class, 'workspace-status')]/span[text()='%s']";
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It may be reasonable to use debug-id here instead of xpath,

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It will be done by #6686.

String WORKSPACE_TITLE = "//div[contains(@class,'toolbar-info')]/span[text()='%s']";
String DELETE_BTN_DIALOG_WIND =
"//button[@ng-click='cheConfirmDialogController.hide()']//span[text()='Delete']";
Expand Down