Stabilize ProjectStateAfterRefreshTest and EditorValidationTest selenium tests #7195
Conversation
Ohrimenko1988
added
kind/task
| @@ -71,10 +71,10 @@ public void autoCompleteClassInTheSamePackage() { | |||
| PROJECT_NAME + "/src/main/java/org/eclipse/qa/examples/AppController.java"); | |||
| editor.waitActiveEditor(); | |||
| // validation warnings | |||
| editor.waitAllMarkersDisappear(ERROR_MARKER); | |||
There was a problem hiding this comment.
Why it was removed? It was an important check - ensure that there are no error markers just after the AppController.java has opened, wasn't it?
There was a problem hiding this comment.
As you see this check is not removed, it is moved to another place, this is related to test logic
There was a problem hiding this comment.
Another place - is after the start of editing file, and previous check of absence of warning just after the file opened IMHO is also important thing and also ought to be checked somewhere. Do we have similar check in another test?
There was a problem hiding this comment.
By the way - I reviewed last 10 test executions here https://ci.codenvycorp.com/view/qa/job/che-integration-tests-che6/ and can't find failures because of method waitAllMarkersDisappear() in which you removed to make the test stable.
Could you, please, write a link to the report of the error in the method waitAllMarkersDisappear during the test execution on CI?
…ong wait to the waitAllMarkersDisappear method
| @@ -703,7 +703,7 @@ public void waitMarkerDisappears(String markerType, int position) { | |||
| * @param markerType is type of the marker | |||
| */ | |||
| public void waitAllMarkersDisappear(String markerType) { | |||
| loaderDriverWait.until( | |||
| elemDriverWait.until( | |||
There was a problem hiding this comment.
elemDriverWait is 3 times less timeout compare to loaderDriverWait. So it's hardly ever to help to stabilize the tests.
Ohrimenko1988
removed
the
status/code-review
What does this PR do?
Rework several steps in the ProjectStateAfterRefreshTest and EditorValidationTest selenium tests for more stable work.
What issues does this PR fix or reference?
Issue: #7180
Release Notes
Docs PR