Add "waitCommandIsSelected" method to the "CommandsExplorer" page-object in selenium tests #7467
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Ohrimenko1988
added
kind/bug
tolusha
approved these changes
Nov 20, 2017
…ium-commandexplorer
dmytro-ndp
reviewed
Nov 20, 2017
| public void waitCommandIsSelected(String commandName) { | ||
| String locator = | ||
| String.format( | ||
| "//div[@id='command_%s' and contains(concat(' ', normalize-space(@class), ' '), ' selected')]", |
There was a problem hiding this comment.
Can we avoid "concat(' ', normalize-space(@Class), ' ')" here by rewriting the xpath to the:
//div[@id='command_%s' and contains(normalize-space(@class), 'selected')
?
There was a problem hiding this comment.
On my regret no, in this case, this is the best way
There was a problem hiding this comment.
The simpler variant looks even better IMHO:
|
Do we need MySuite.xml ? |
|
@tolusha no, this is a temporary suite for fast check a factory on CI, it will be removed after check the factory functionality. |
|
Rename it respectively then |
tolusha
approved these changes
Nov 21, 2017
This was referenced Nov 21, 2017
dmytro-ndp
approved these changes
Nov 22, 2017
Ohrimenko1988
removed
the
status/code-review
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Add "waitCommandIsSelected" method to the "CommandsExplorer" page-object and update "selectCommandByName" method with new check.
What issues does this PR fix or reference?
Issue #7364
Release Notes
Docs PR