Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor ProjectExplorer page-object in the selenium tests #7631

Merged
merged 21 commits into from
Dec 20, 2017
Merged

Refactor ProjectExplorer page-object in the selenium tests #7631

merged 21 commits into from
Dec 20, 2017

Conversation

Ohrimenko1988
Copy link
Contributor

What does this PR do?

Refactoring of methods in the ProjectExplorer page-object

What issues does this PR fix or reference?

Issue: #7605

Release Notes

Docs PR

@Ohrimenko1988 Ohrimenko1988 added status/code-review This issue has a pull request posted for it and is awaiting code review completion by the community. target/che6 labels Nov 29, 2017
@benoitf benoitf added the kind/bug Outline of a bug - must adhere to the bug report template. label Nov 29, 2017
@Ohrimenko1988
Copy link
Contributor Author

ci-test

@codenvy-ci
Copy link

ci-test build report:
Build details
Test report
selenium tests report data
https://github.com/orgs/eclipse/teams/eclipse-che-qa please check this report.

@dmytro-ndp dmytro-ndp removed their request for review November 30, 2017 14:37
@Ohrimenko1988
Copy link
Contributor Author

ci-test

dmytro-ndp
dmytro-ndp reviewed Nov 30, 2017
View reviewed changes
...ium/che-selenium-test/src/main/java/org/eclipse/che/selenium/pageobject/ProjectExplorer.java Outdated
/**
* @param path path to item in Project Explorer
* @param timeout timeout in seconds
* @return finded WebElement
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

finded > found

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ok, thx

@codenvy-ci
Copy link

ci-test build report:
Build details
Test report
selenium tests report data
https://github.com/orgs/eclipse/teams/eclipse-che-qa please check this report.

@Ohrimenko1988
Copy link
Contributor Author

ci-test

@codenvy-ci
Copy link

ci-test build report:
Build details
Test report
selenium tests report data
https://github.com/orgs/eclipse/teams/eclipse-che-qa please check this report.

@Ohrimenko1988
Copy link
Contributor Author

ci-test

@codenvy-ci
Copy link

ci-test build report:
Build details
Test report
selenium tests report data
https://github.com/orgs/eclipse/teams/eclipse-che-qa please check this report.

dmytro-ndp
dmytro-ndp reviewed Dec 19, 2017
View reviewed changes
...ium/che-selenium-test/src/main/java/org/eclipse/che/selenium/pageobject/ProjectExplorer.java Outdated
public void selectMultiFilesByShiftKeyWithCheckMultiselection(
String clickItemPath, List<String> selectedItemsPaths) {
Actions actions = actionsFactory.createAction(seleniumWebDriver);
actions.keyDown(Keys.SHIFT).perform();
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's use static import for simplifying constant references similar to how it had been done in other parts of code.

dmytro-ndp
dmytro-ndp reviewed Dec 19, 2017
View reviewed changes
...ium/che-selenium-test/src/main/java/org/eclipse/che/selenium/pageobject/ProjectExplorer.java Outdated
ExpectedConditions.not(
ExpectedConditions.presenceOfAllElementsLocatedBy(By.xpath(locator))));
loadPageTimeout.until(
ExpectedConditions.not(
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's use static import for simplifying static method references similar to how it had been done in other parts of code.

@Ohrimenko1988
Copy link
Contributor Author

ci-test

@codenvy-ci
Copy link

ci-test build report:
Build details
Test report
selenium tests report data
https://github.com/orgs/eclipse/teams/eclipse-che-qa please check this report.

@dmytro-ndp
Copy link
Contributor

@Ohrimenko1988: could you, please, take a look at the weird failures of the next tests from the latest ci-test execution:

They have been stable during the last 6 runs at the https://ci.codenvycorp.com/view/qa/job/che-integration-tests-che6/

@Ohrimenko1988
Copy link
Contributor Author

@dmytro-ndp
for
org.eclipse.che.selenium.workspaces.ProjectStateAfterRefreshTest#checkRestoreStateOfProjectAfterRefreshTest
it looks like in this issue the similar problem:
#7551

for
org.eclipse.che.selenium.factory.CheckFactoryWithSparseCheckoutTest#acceptFactoryWithSparseCheckout
issue
#7959

@Ohrimenko1988 Ohrimenko1988 merged commit 28ca6c5 into che6 Dec 20, 2017
@Ohrimenko1988 Ohrimenko1988 deleted the update-click-on-context-menu-item branch December 20, 2017 08:39
@benoitf benoitf removed the status/code-review This issue has a pull request posted for it and is awaiting code review completion by the community. label Dec 20, 2017
@benoitf benoitf added this to the 6.0.0-M4 milestone Dec 20, 2017
This was referenced Dec 20, 2017
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dmytro-ndp dmytro-ndp dmytro-ndp approved these changes

@tolusha tolusha tolusha approved these changes

@SkorikSergey SkorikSergey SkorikSergey approved these changes

@vparfonov vparfonov Awaiting requested review from vparfonov

@musienko-maxim musienko-maxim Awaiting requested review from musienko-maxim

@artaleks9 artaleks9 Awaiting requested review from artaleks9

Assignees
No one assigned
Labels
kind/bug Outline of a bug - must adhere to the bug report template.
Projects
None yet
Milestone
6.0.0-M4
Development

Successfully merging this pull request may close these issues.
6 participants
@Ohrimenko1988 @codenvy-ci @dmytro-ndp @tolusha @SkorikSergey @benoitf