Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improves debug panel, fixes UI of configure breakpoints popup #8520

Merged
merged 2 commits into from
Jan 30, 2018
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Original file line number Diff line number Diff line change
Expand Up @@ -339,7 +339,7 @@ void onThreadChanged(ChangeEvent event) {

private SimpleList<ActiveBreakpointWrapper> createBreakpointList() {
TableElement breakPointsElement = Elements.createTableElement();
breakPointsElement.setAttribute("style", "width: 100%");
breakPointsElement.setAttribute("style", "width: 100%; border: none;");

SimpleList.ListEventDelegate<ActiveBreakpointWrapper> breakpointListEventDelegate =
new SimpleList.ListEventDelegate<ActiveBreakpointWrapper>() {
Expand Down Expand Up @@ -369,7 +369,7 @@ public void onListItemDoubleClicked(

private SimpleList<StackFrameDump> createFramesList() {
TableElement frameElement = Elements.createTableElement();
frameElement.setAttribute("style", "width: 100%");
frameElement.setAttribute("style", "width: 100%; border: none;");

SimpleList.ListEventDelegate<StackFrameDump> frameListEventDelegate =
new SimpleList.ListEventDelegate<StackFrameDump>() {
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,8 @@
xmlns:g='urn:import:com.google.gwt.user.client.ui'>
<ui:with field='locale' type='org.eclipse.che.plugin.debugger.ide.DebuggerLocalizationConstant'/>
<ui:with field='coreRes' type='org.eclipse.che.ide.Resources'/>
<ui:style>

<ui:style src="org/eclipse/che/ide/api/ui/style.css">
.executionPoint {
font-weight: bold;
}
Expand Down Expand Up @@ -50,7 +51,12 @@
height: 100%;
width: 100%;
}

.list {
background: textFieldBackgroundColor;
}
</ui:style>

<g:DockLayoutPanel unit="PX" width="100%" height="100%">
<g:north size="26.0">
<g:FlowPanel width="100%" height="100%" debugId="debugger-upper-panel">
Expand All @@ -69,7 +75,7 @@
<g:Label text="{locale.breakpoints}" addStyleNames="{style.alignLeft}"/>
</g:north>
<g:center>
<g:ScrollPanel ui:field="breakpointsPanel" addStyleNames="{coreRes.coreCss.simpleListContainer}"
<g:ScrollPanel ui:field="breakpointsPanel" addStyleNames="{style.list} {coreRes.coreCss.simpleListContainer}"
debugId="debugger-breakpointsPanel"/>
</g:center>
</g:DockLayoutPanel>
Expand All @@ -94,8 +100,8 @@
debugId="thread-not-suspended">
<g:Label text="{locale.debuggerThreadNotSuspend}"/>
</g:FlowPanel>
<g:ScrollPanel addStyleNames="{coreRes.coreCss.simpleListContainer}"
debugId="debugger-frames-list" width="100%" ui:field="framesPanel"/>
<g:ScrollPanel addStyleNames="{style.list} {coreRes.coreCss.simpleListContainer}"
debugId="debugger-frames-list" width="100%" height="100%" ui:field="framesPanel"/>
</g:FlowPanel>
</g:center>
</g:DockLayoutPanel>
Expand All @@ -111,7 +117,7 @@
<g:SimplePanel ui:field="watchExpressionPanel" debugId="watch-expression-panel"/>
</g:west>
<g:center>
<tree:Tree ui:field="tree" addStyleNames="{coreRes.coreCss.simpleListContainer}"/>
<tree:Tree ui:field="tree" addStyleNames="{style.list} {coreRes.coreCss.simpleListContainer}"/>
</g:center>
</g:DockLayoutPanel>
</g:FlowPanel>
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -64,4 +64,9 @@ public void render(Element itemElement, StackFrameDump itemData) {
label.setInnerHTML(sb.toSafeHtml().asString());
itemElement.appendChild(label);
}

@Override
public Element createElement() {
return Elements.createTRElement();
}
}
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,7 @@
<ui:style>
.condition {
margin-left: 5px;
width: 310px;
width: 300px;
}

.hitCount {
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -121,4 +121,4 @@ input.filterPlaceholder::-moz-placeholder {
background-repeat: no-repeat;
background-position: literal("calc(50% - 25px)") center;
background-size: contain;
}
}
Original file line number Diff line number Diff line change
Expand Up @@ -18,4 +18,4 @@
display: inline-block;
text-decoration: none;
padding: 0px 3px 0px 3px;
}
}