Add informative messages to the loaders it will helpful for error det…

plugins/plugin-java/che-plugin-java-ext-lang-client/src/main/java/org/eclipse/che/ide/ext/java/client/navigation/filestructure/FileStructurePresenter.java

@@ -16,7 +16,6 @@
 import com.google.inject.Singleton;
 import org.eclipse.che.api.promises.client.Operation;
 import org.eclipse.che.api.promises.client.OperationException;
-import org.eclipse.che.api.promises.client.PromiseError;
 import org.eclipse.che.ide.api.app.AppContext;
 import org.eclipse.che.ide.api.editor.EditorAgent;
 import org.eclipse.che.ide.api.editor.EditorPartPresenter;
@@ -35,11 +34,9 @@
 import org.eclipse.che.ide.ext.java.shared.JarEntry;
 import org.eclipse.che.ide.ext.java.shared.dto.ClassContent;
 import org.eclipse.che.ide.ext.java.shared.dto.Region;
-import org.eclipse.che.ide.ext.java.shared.dto.model.CompilationUnit;
 import org.eclipse.che.ide.ext.java.shared.dto.model.Member;
 import org.eclipse.che.ide.resource.Path;
 import org.eclipse.che.ide.ui.loaders.request.LoaderFactory;
-import org.eclipse.che.ide.ui.loaders.request.MessageLoader;
 import org.eclipse.che.ide.util.loging.Log;
 
 /**
@@ -54,7 +51,6 @@ public class FileStructurePresenter implements FileStructure.ActionDelegate {
   private final JavaNavigationService javaNavigationService;
   private final AppContext context;
   private final EditorAgent editorAgent;
-  private final MessageLoader loader;
 
   private TextEditor activeEditor;
   private boolean showInheritedMembers;
@@ -71,7 +67,6 @@ public FileStructurePresenter(
     this.javaNavigationService = javaNavigationService;
     this.context = context;
     this.editorAgent = editorAgent;
-    this.loader = loaderFactory.newLoader();
     this.view.setDelegate(this);
   }
 
@@ -81,8 +76,8 @@ public FileStructurePresenter(
    * @param editorPartPresenter the active editor
    */
   public void show(EditorPartPresenter editorPartPresenter) {
-    loader.show();
     view.setTitle(editorPartPresenter.getEditorInput().getFile().getName());
+    view.show();
 
     if (!(editorPartPresenter instanceof TextEditor)) {
       Log.error(getClass(), "Open Declaration support only TextEditor as editor");
@@ -103,26 +98,16 @@ public void show(EditorPartPresenter editorPartPresenter) {
       }
 
       final String fqn = JavaUtil.resolveFQN((Container) srcFolder.get(), (Resource) file);
-
       javaNavigationService
           .getCompilationUnit(project.get().getLocation(), fqn, showInheritedMembers)
           .then(
-              new Operation<CompilationUnit>() {
-                @Override
-                public void apply(CompilationUnit unit) throws OperationException {
-                  view.setStructure(unit, showInheritedMembers);
-                  showInheritedMembers = !showInheritedMembers;
-                  loader.hide();
-                  view.show();
-                }
+              unit -> {
+                view.setStructure(unit, showInheritedMembers);
+                showInheritedMembers = !showInheritedMembers;
               })
           .catchError(
-              new Operation<PromiseError>() {
-                @Override
-                public void apply(PromiseError arg) throws OperationException {
-                  Log.error(FileStructurePresenter.class, arg.getMessage());
-                  loader.hide();
-                }
+              arg -> {
+                Log.error(FileStructurePresenter.class, arg.getMessage());
               });
     }
   }

plugins/plugin-java/che-plugin-java-ext-lang-client/src/main/java/org/eclipse/che/ide/ext/java/client/navigation/service/JavaNavigationServiceImpl.java

@@ -272,6 +272,7 @@ public Promise<CompilationUnit> getCompilationUnit(
     return requestFactory
         .createGetRequest(url)
         .header(ACCEPT, APPLICATION_JSON)
+        .loader(loaderFactory.newLoader("Getting information about ..."))
         .send(unmarshallerFactory.newUnmarshaller(CompilationUnit.class));
   }
 

plugins/plugin-java/che-plugin-java-ext-lang-client/src/main/java/org/eclipse/che/ide/ext/java/client/refactoring/service/RefactoringServiceClientImpl.java

@@ -41,7 +41,6 @@
 import org.eclipse.che.ide.rest.DtoUnmarshallerFactory;
 import org.eclipse.che.ide.rest.StringUnmarshaller;
 import org.eclipse.che.ide.ui.loaders.request.LoaderFactory;
-import org.eclipse.che.ide.ui.loaders.request.MessageLoader;
 
 /**
  * @author Dmitry Shnurenko
@@ -54,8 +53,8 @@ final class RefactoringServiceClientImpl implements RefactoringServiceClient {
   private final AsyncRequestFactory asyncRequestFactory;
   private final DtoUnmarshallerFactory unmarshallerFactory;
   private final AppContext appContext;
+  private final LoaderFactory loaderFactory;
   private final String pathToService;
-  private final MessageLoader loader;
 
   @Inject
   public RefactoringServiceClientImpl(
@@ -66,7 +65,7 @@ public RefactoringServiceClientImpl(
     this.asyncRequestFactory = asyncRequestFactory;
     this.unmarshallerFactory = unmarshallerFactory;
     this.appContext = appContext;
-    this.loader = loaderFactory.newLoader();
+    this.loaderFactory = loaderFactory;
     this.pathToService = "/java/refactoring/";
   }
 
@@ -79,7 +78,7 @@ public Promise<String> createMoveRefactoring(final CreateMoveRefactoring moveRef
             moveRefactoring)
         .header(ACCEPT, TEXT_PLAIN)
         .header(CONTENT_TYPE, APPLICATION_JSON)
-        .loader(loader)
+        .loader(loaderFactory.newLoader("Prepare for move refactoring ..."))
         .send(new StringUnmarshaller());
   }
 
@@ -92,7 +91,7 @@ public Promise<RenameRefactoringSession> createRenameRefactoring(
         .createPostRequest(url, settings)
         .header(ACCEPT, APPLICATION_JSON)
         .header(CONTENT_TYPE, APPLICATION_JSON)
-        .loader(loader)
+        .loader(loaderFactory.newLoader("Prepare for rename refactoring ..."))
         .send(unmarshallerFactory.newUnmarshaller(RenameRefactoringSession.class));
   }
 
@@ -106,7 +105,7 @@ public Promise<RefactoringResult> applyLinkedModeRename(
         .createPostRequest(url, refactoringApply)
         .header(ACCEPT, APPLICATION_JSON)
         .header(CONTENT_TYPE, APPLICATION_JSON)
-        .loader(loader)
+        .loader(loaderFactory.newLoader("Apply linked mode rename refactoring ..."))
         .send(unmarshallerFactory.newUnmarshaller(RefactoringResult.class));
   }
 
@@ -119,7 +118,7 @@ public Promise<RefactoringStatus> setDestination(final ReorgDestination destinat
         .createPostRequest(url, destination)
         .header(ACCEPT, APPLICATION_JSON)
         .header(CONTENT_TYPE, APPLICATION_JSON)
-        .loader(loader)
+        .loader(loaderFactory.newLoader("Set move refactoring destination..."))
         .send(unmarshallerFactory.newUnmarshaller(RefactoringStatus.class));
   }
 
@@ -133,7 +132,7 @@ public Promise<Void> setMoveSettings(final MoveSettings settings) {
         .createPostRequest(url, settings)
         .header(ACCEPT, APPLICATION_JSON)
         .header(CONTENT_TYPE, APPLICATION_JSON)
-        .loader(loader)
+        .loader(loaderFactory.newLoader("Set move refactoring settings ..."))
         .send();
   }
 
@@ -146,7 +145,7 @@ public Promise<ChangeCreationResult> createChange(final RefactoringSession sessi
         .createPostRequest(url, session)
         .header(ACCEPT, APPLICATION_JSON)
         .header(CONTENT_TYPE, APPLICATION_JSON)
-        .loader(loader)
+        .loader(loaderFactory.newLoader("Creating refactoring changes"))
         .send(unmarshallerFactory.newUnmarshaller(ChangeCreationResult.class));
   }
 
@@ -159,7 +158,7 @@ public Promise<RefactoringPreview> getRefactoringPreview(final RefactoringSessio
         .createPostRequest(url, session)
         .header(ACCEPT, APPLICATION_JSON)
         .header(CONTENT_TYPE, APPLICATION_JSON)
-        .loader(loader)
+        .loader(loaderFactory.newLoader("Getting preview ..."))
         .send(unmarshallerFactory.newUnmarshaller(RefactoringPreview.class));
   }
 
@@ -172,7 +171,7 @@ public Promise<RefactoringResult> applyRefactoring(final RefactoringSession sess
         .createPostRequest(url, session)
         .header(ACCEPT, APPLICATION_JSON)
         .header(CONTENT_TYPE, APPLICATION_JSON)
-        .loader(loader)
+        .loader(loaderFactory.newLoader("Apply refactoring ... "))
         .send(unmarshallerFactory.newUnmarshaller(RefactoringResult.class));
   }
 
@@ -185,7 +184,7 @@ public Promise<Void> changeChangeEnabledState(final ChangeEnabledState state) {
         .createPostRequest(url, state)
         .header(ACCEPT, APPLICATION_JSON)
         .header(CONTENT_TYPE, APPLICATION_JSON)
-        .loader(loader)
+        .loader(loaderFactory.newLoader("Choosing some change ..."))
         .send();
   }
 
@@ -198,7 +197,7 @@ public Promise<ChangePreview> getChangePreview(final RefactoringChange change) {
         .createPostRequest(url, change)
         .header(ACCEPT, APPLICATION_JSON)
         .header(CONTENT_TYPE, APPLICATION_JSON)
-        .loader(loader)
+        .loader(loaderFactory.newLoader("Get refactoring change preview"))
         .send(unmarshallerFactory.newUnmarshaller(ChangePreview.class));
   }
 
@@ -212,7 +211,7 @@ public Promise<RefactoringStatus> validateNewName(final ValidateNewName newName)
         .createPostRequest(url, newName)
         .header(ACCEPT, APPLICATION_JSON)
         .header(CONTENT_TYPE, APPLICATION_JSON)
-        .loader(loader)
+        .loader(loaderFactory.newLoader("Validates new name ..."))
         .send(unmarshallerFactory.newUnmarshaller(RefactoringStatus.class));
   }
 
@@ -226,7 +225,7 @@ public Promise<Void> setRenameSettings(final RenameSettings settings) {
         .createPostRequest(url, settings)
         .header(ACCEPT, APPLICATION_JSON)
         .header(CONTENT_TYPE, APPLICATION_JSON)
-        .loader(loader)
+        .loader(loaderFactory.newLoader("Set rename refactoring settings"))
         .send();
   }
 
@@ -238,6 +237,9 @@ public Promise<Void> reindexProject(String projectPath) {
             + "reindex?projectpath="
             + encodePath(valueOf(projectPath));
 
-    return asyncRequestFactory.createGetRequest(url).loader(loader).send();
+    return asyncRequestFactory
+        .createGetRequest(url)
+        .loader(loaderFactory.newLoader("Reindexing project ..."))
+        .send();
   }
 }