Selenium: change a way for selecting an element from suggestions list #8736
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SkorikSergey
added
status/code-review
dmytro-ndp
reviewed
Feb 12, 2018
| By.xpath(format(Locators.FILE_NAME_LIST_SELECT, nameOfFile)))); | ||
|
|
||
| webElement.click(); | ||
| WaitUtils.sleepQuietly(500, MILLISECONDS); |
There was a problem hiding this comment.
Please, add comment to explain why we should wait so long here.
There was a problem hiding this comment.
It is timeout between selecting element and double click on it. 0.5 sec is not so long.
|
ci-test |
dmytro-ndp
approved these changes
Feb 12, 2018
|
ci-test build report: |
benoitf
removed
the
status/code-review
hkolvenbach
pushed a commit
to hkolvenbach/che
that referenced
this pull request
Mar 2, 2018
…pdatemaster to master updated to 6.1.0 stable, new keycloak theme * commit 'e58465aaeea236ff051b8176af4581a443c0fd88': (115 commits) fixed fonts and added google fonts fallback added box shadow fix added lato regular as bold added lato light italic updated license header added Lato Light to fonts, removed CHE from login page ST-3764, ST-3613 Create keycloak docker image, and use the latest login theme Remove commented Updated version to 6.1.0 tag [maven-release-plugin] prepare release 6.1.0 RELEASE: Update dependencies versions RELEASE: Update parent pom version RELEASE: Set tags in Dockerfiles CHE-8747. Fix displaying pull request panel (eclipse-che#8760) Add different style for focusable element (eclipse-che#8757) Selenium: Add most common methods to the "SeleniumWebDriverHelper" (eclipse-che#8746) Selenium: increase timeout to check that a menu item is enabled (eclipse-che#8755) Support enter press in refactoring rename form (eclipse-che#8754) Selenium: change a way for selecting an element from suggestions list (eclipse-che#8736) CHE-7278 Properly handle restarting the workspace (eclipse-che#8612) ...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
This PR modifies the selectFileByName method to send double-click on the found web element(not just double click).
What issues does this PR fix or reference?
#8465