Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Revert "Fix orion document changing event getting text from native orion event instead of guessing it" #8823

Merged
merged 1 commit into from
Feb 18, 2018
Merged

Revert "Fix orion document changing event getting text from native orion event instead of guessing it" #8823

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions ...ore-orion-editor/src/main/java/org/eclipse/che/ide/editor/orion/client/OrionDocument.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -91,7 +91,7 @@ private void fireDocumentChangeEvent(final ModelChangedEventOverlay param) {
int addedCharCount = param.addedCharCount();
int removedCharCount = param.removedCharCount();

String text = param.getText();
String text = editorOverlay.getModel().getText(startOffset, startOffset + addedCharCount);

final DocumentChangedEvent event =
new DocumentChangedEvent(this, startOffset, addedCharCount, text, removedCharCount);
Expand All @@ -104,7 +104,7 @@ private void fireDocumentChangingEvent(final ModelChangedEventOverlay param) {
int addedCharCount = param.addedCharCount();
int removedCharCount = param.removedCharCount();

String text = param.getText();
String text = editorOverlay.getModel().getText(startOffset, startOffset + addedCharCount);

final DocumentChangingEvent event =
new DocumentChangingEvent(this, startOffset, addedCharCount, text, removedCharCount);
Expand Down
4 changes: 0 additions & 4 deletions ...r/src/main/java/org/eclipse/che/ide/editor/orion/client/jso/ModelChangedEventOverlay.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -42,8 +42,4 @@ public final native int removedLineCount() /*-{
public final native int start() /*-{
return this.start;
}-*/;

public final native String getText() /*-{
return this.text;
}-*/;
}