Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Selenium: Rework methods from "CodenvyEditor" page object with using "SeleniumWebDriverHelper" and "WebDriverWaitFactory" classes #8980

Merged
merged 18 commits into from
Mar 2, 2018
Merged

Selenium: Rework methods from "CodenvyEditor" page object with using "SeleniumWebDriverHelper" and "WebDriverWaitFactory" classes #8980

merged 18 commits into from
Mar 2, 2018

Commits on Feb 28, 2018

  1. Group locators from CodenvyEditor page object to enumerations and do … 

    …changes in related methods
    @Ohrimenko1988
    Ohrimenko1988 committed Feb 28, 2018
    Configuration menu
    Copy the full SHA
    7a36901 View commit details
    Browse the repository at this point in the history

  2. Transform the 'Locators' abstract class from 'CodenvyEditor' page obj… 

    …ect into the interface
    @Ohrimenko1988
    Ohrimenko1988 committed Feb 28, 2018
    Configuration menu
    Copy the full SHA
    9b4479a View commit details
    Browse the repository at this point in the history

  3. Remove unused webelements

    @Ohrimenko1988
    Ohrimenko1988 committed Feb 28, 2018
    Configuration menu
    Copy the full SHA
    90413dc View commit details
    Browse the repository at this point in the history

  4. Move enumerations with locators to another place in the 'CodenvyEdito… 

    …r' page object's body
    @Ohrimenko1988
    Ohrimenko1988 committed Feb 28, 2018
    Configuration menu
    Copy the full SHA
    e35b3d5 View commit details
    Browse the repository at this point in the history

  5. Remove redundant whitespaces

    @Ohrimenko1988
    Ohrimenko1988 committed Feb 28, 2018
    Configuration menu
    Copy the full SHA
    bb0b149 View commit details
    Browse the repository at this point in the history

  6. Merge branch 'master' of https://github.com/eclipse/che into selen-re… 

    …vork-methods-editor
    @Ohrimenko1988
    Ohrimenko1988 committed Feb 28, 2018
    Configuration menu
    Copy the full SHA
    07fd658 View commit details
    Browse the repository at this point in the history

  7. Change of returning type of 'TabAction' and 'EditorContextMenu' enume… 

    …rations from 'String' to 'By'
    @Ohrimenko1988
    Ohrimenko1988 committed Feb 28, 2018
    Configuration menu
    Copy the full SHA
    0bbdd8f View commit details
    Browse the repository at this point in the history

  8. Do changes according to review

    @Ohrimenko1988
    Ohrimenko1988 committed Feb 28, 2018
    Configuration menu
    Copy the full SHA
    f63433d View commit details
    Browse the repository at this point in the history

  9. Change name of enumeration from 'Marker' to 'MarkerLocator'

    @Ohrimenko1988
    Ohrimenko1988 committed Feb 28, 2018
    Configuration menu
    Copy the full SHA
    89d186e View commit details
    Browse the repository at this point in the history

  10. Do changes according to review

    @Ohrimenko1988
    Ohrimenko1988 committed Feb 28, 2018
    Configuration menu
    Copy the full SHA
    7b99a1a View commit details
    Browse the repository at this point in the history

Commits on Mar 1, 2018

  1. Merge branch 'selen-revork-const-editor' of https://github.com/eclips… 

    …e/che into selen-revork-methods-editor
    @Ohrimenko1988
    Ohrimenko1988 committed Mar 1, 2018
    Configuration menu
    Copy the full SHA
    d39dc1c View commit details
    Browse the repository at this point in the history

  2. Merge branch 'master' of https://github.com/eclipse/che into selen-re… 

    …vork-methods-editor
    @Ohrimenko1988
    Ohrimenko1988 committed Mar 1, 2018
    Configuration menu
    Copy the full SHA
    cb52059 View commit details
    Browse the repository at this point in the history

  3. Rework methods from CodenvyEditor page object with using SeleniumWebD… 

    …riverHelper and WebDriverWaitFactory classes
    @Ohrimenko1988
    Ohrimenko1988 committed Mar 1, 2018
    Configuration menu
    Copy the full SHA
    659692f View commit details
    Browse the repository at this point in the history

  4. Merge master and resolve conflicts

    @Ohrimenko1988
    Ohrimenko1988 committed Mar 1, 2018
    Configuration menu
    Copy the full SHA
    2182ed9 View commit details
    Browse the repository at this point in the history

Commits on Mar 2, 2018

  1. Merge branch 'master' of https://github.com/eclipse/che into selen-re… 

    …vork-methods-editor
    @Ohrimenko1988
    Ohrimenko1988 committed Mar 2, 2018
    Configuration menu
    Copy the full SHA
    003a822 View commit details
    Browse the repository at this point in the history

  2. Create 'get()' method for 'WebDriverWaitFactory' with default timeout… 

    … and apply this changes in the 'CodenvyEditor' page object
    @Ohrimenko1988
    Ohrimenko1988 committed Mar 2, 2018
    Configuration menu
    Copy the full SHA
    ea2fad6 View commit details
    Browse the repository at this point in the history

  3. Remove unused 'WebDriverWait' objects

    @Ohrimenko1988
    Ohrimenko1988 committed Mar 2, 2018
    Configuration menu
    Copy the full SHA
    924ba87 View commit details
    Browse the repository at this point in the history

  4. Remove checking of selection from 'CodenvyEditor#enterTextIntoFixErro… 

    …rPropByDoubleClick(String expectedItem)' and remove 'try/catch' blocks from related tests
    @Ohrimenko1988
    Ohrimenko1988 committed Mar 2, 2018
    Configuration menu
    Copy the full SHA
    dd91b01 View commit details
    Browse the repository at this point in the history