Selenium: check that the IDE is loaded before switching to IDE application frame #9117
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SkorikSergey
added
kind/bug
musienko-maxim
approved these changes
Mar 16, 2018
dmytro-ndp
reviewed
Mar 16, 2018
| } | ||
|
|
||
| public void switchFromDashboardIframeToIde(int timeout) { | ||
| new WebDriverWait(this, timeout) | ||
| .until(ExpectedConditions.frameToBeAvailableAndSwitchToIt(By.id("ide-application-iframe"))); | ||
| .until(visibilityOfElementLocated(By.id("ide-application-iframe"))); |
There was a problem hiding this comment.
There is method wait(timeout) below in the class. You can use it to simplify the code.
benoitf
removed
the
status/code-review
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
This PR adds to switchFromDashboardIframeToIde method checking that the IDE is loaded before switching to IDE application frame.
What issues does this PR fix or reference?
#9100