make KC configuration before CHE start in case of deploy to OS #9181
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
make KC configuration before CHE pod start
riuvshin
changed the title
benoitf
added
the
status/code-review
garagatyi
approved these changes
Mar 22, 2018
l0rd
approved these changes
Mar 22, 2018
ghost
approved these changes
Mar 22, 2018
benoitf
removed
the
status/code-review
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
make KC configuration before CHE start
with changes introduced in #8650 CHE calling KC during start-up
while deploy script performed KC configuration AFTER CHE pod is fully deployed. So CHE was failed to start because KC was not ready on it's start and due to another bug fixed by #9168 CHE liveness probe didn't work properly and CHE pod in failed state was treated as healthy
needed for: #8650