Selenium: add method for switching from Dashboard to IDE frame in SeleniumWebDriverHelper class #9262

SkorikSergey · 2018-03-27T15:19:55Z

What does this PR do?

This PR adds switchFromDashboardAndWaitProjectExplorer method for switching from Dashboard to IDE frame in SeleniumWebDriverHelper class.

What issues does this PR fix or reference?

#9100

…lorer() method

…omDashboardToIdeFrame

dmytro-ndp · 2018-03-27T16:27:23Z

...enium-test/src/test/java/org/eclipse/che/selenium/dashboard/WorkspaceDetailsComposeTest.java

@@ -57,6 +58,7 @@
  @Inject private Dashboard dashboard;
  @Inject private WorkspaceDetails workspaceDetails;
  @Inject private SeleniumWebDriver seleniumWebDriver;


seleniumWebDriver looks redundant in class.

dmytro-ndp · 2018-03-27T16:28:16Z

...ium-test/src/test/java/org/eclipse/che/selenium/factory/CheckFactoryWithMultiModuleTest.java

@@ -44,6 +45,7 @@
  private String gitHubUsername;

  @Inject private SeleniumWebDriver seleniumWebDriver;


seleniumWebDriver looks redundant in class.

SeleniumWebDriver is needed in some factory tests for factory url opening(TestFactory.open(seleniumWebDriver)).

Looks like an issue. It seems we can easily reuse field TestFactory#seleniumWebDriver inside the open() method instead of argument seleniumWebDriver.

dmytro-ndp · 2018-03-27T16:31:36Z

...e-selenium-test/src/test/java/org/eclipse/che/selenium/factory/CheckOpenFileFeatureTest.java

@@ -85,7 +87,7 @@ public void checkOpenFileFeatureTest() throws Exception {
    String currentWin = seleniumWebDriver.getWindowHandle();
    seleniumWebDriver.switchToNoneCurrentWindow(currentWin);


We can move SeleniumWebDriver#switchToNoneCurrentWindow(currentWin) method to the SeleniumWebDriverHelper as well, can't we?

dmytro-ndp · 2018-03-27T16:33:15Z

SeleniumWebDriver seleniumWebDriver; field becomes redundant in the most test classes after refactoring. Please, remove such fields.

dmytro-ndp · 2018-03-27T16:34:22Z

It worth to move SeleniumWebDriver#switchToNoneCurrentWindow(currentWin) method to the SeleniumWebDriverHelper class as well.

Ohrimenko1988 · 2018-03-28T06:41:25Z

...selenium-test/src/main/java/org/eclipse/che/selenium/pageobject/SeleniumWebDriverHelper.java

@@ -766,4 +768,21 @@ public void waitAndSwitchToFrame(WebElement frame, int timeout) {
  public void waitAndSwitchToFrame(WebElement frame) {
    waitAndSwitchToFrame(frame, DEFAULT_TIMEOUT);
  }
+
+  /** Switch to IDE frame and wait that Project Explorer is visible */
+  public void switchFromDashboardAndWaitProjectExplorer() {


Please create an override of this method with a custom timeout in argument

public void switchFromDashboardAndWaitProjectExplorer(int timeout)

Ohrimenko1988 · 2018-03-28T06:43:20Z

...selenium-test/src/main/java/org/eclipse/che/selenium/pageobject/SeleniumWebDriverHelper.java

@@ -766,4 +768,21 @@ public void waitAndSwitchToFrame(WebElement frame, int timeout) {
  public void waitAndSwitchToFrame(WebElement frame) {
    waitAndSwitchToFrame(frame, DEFAULT_TIMEOUT);
  }
+
+  /** Switch to IDE frame and wait that Project Explorer is visible */


Switch -> Switches ; wait -> waits

Ohrimenko1988 · 2018-03-28T06:47:04Z

...selenium-test/src/main/java/org/eclipse/che/selenium/pageobject/SeleniumWebDriverHelper.java

@@ -766,4 +768,21 @@ public void waitAndSwitchToFrame(WebElement frame, int timeout) {
  public void waitAndSwitchToFrame(WebElement frame) {
    waitAndSwitchToFrame(frame, DEFAULT_TIMEOUT);
  }
+
+  /** Switch to IDE frame and wait that Project Explorer is visible */
+  public void switchFromDashboardAndWaitProjectExplorer() {


And about method name. What do you think about

switchToIdeFrameAndWaitAvailability

…omDashboardToIdeFrame

…deFrameAndWaitAvailability

SkorikSergey · 2018-03-30T10:02:06Z

ci-test

codenvy-ci · 2018-03-30T10:38:55Z

ci-test build report:
Build details
Test report
selenium tests report data
docker image: eclipseche/che-server:9262
https://github.com/orgs/eclipse/teams/eclipse-che-qa please check this report.

SkorikSergey · 2018-03-30T11:06:03Z

ci-test

codenvy-ci · 2018-03-30T17:00:55Z

ci-test build report:
Build details
Test report
selenium tests report data
docker image: eclipseche/che-server:9262
https://github.com/orgs/eclipse/teams/eclipse-che-qa please check this report.

SkorikSergey · 2018-04-01T20:29:58Z

ci-test

codenvy-ci · 2018-04-02T05:43:22Z

ci-test build report:
Build details
Test report
selenium tests report data
docker image: eclipseche/che-server:9262
https://github.com/orgs/eclipse/teams/eclipse-che-qa please check this report.

dmytro-ndp · 2018-04-02T14:48:52Z

...enium-test/src/test/java/org/eclipse/che/selenium/dashboard/CreateAndDeleteProjectsTest.java

@@ -83,7 +85,7 @@ public void createAndDeleteProjectTest() throws ExecutionException, InterruptedE
    newWorkspace.clickOnCreateButtonAndOpenInIDE();

    String dashboardWindow = seleniumWebDriver.getWindowHandle();


We could rework seleniumWebDriverHelper.switchToIdeFrameAndWaitAvailability() to return dashboardWindow

dmytro-ndp · 2018-04-02T14:56:19Z

...selenium-test/src/main/java/org/eclipse/che/selenium/pageobject/SeleniumWebDriverHelper.java

+   *
+   * @param currentWindowHandler
+   */
+  public void switchToNoneCurrentWindow(String currentWindowHandler) {


Let's rename the method to make its propose more obvious: switchToNextWindow().
Argument currentWindowHandler is also misleading so as it seems could be any non-current window handler. So, lets rename the argument to be more precise, for example: windowHandlerToSwitchFrom.

…omDashboardToIdeFrame

…andle

SkorikSergey · 2018-04-03T14:50:43Z

ci-test

codenvy-ci · 2018-04-03T20:46:11Z

ci-test build report:
Build details
Test report
selenium tests report data
docker image: eclipseche/che-server:9262
https://github.com/orgs/eclipse/teams/eclipse-che-qa please check this report.

SkorikSergey added 5 commits March 26, 2018 15:04

to SeleniumWebDriverHelper added switchFromDashboardAndWaitProjectExp…

4003f7f

…lorer() method

Merge branch 'master' of https://github.com/eclipse/che into switchFr…

349211c

…omDashboardToIdeFrame

fixed factories tests

e2235b9

Merge branch 'master' of https://github.com/eclipse/che into switchFr…

db94c1f

…omDashboardToIdeFrame

Merge branch 'master' of https://github.com/eclipse/che into switchFr…

f4ebe34

…omDashboardToIdeFrame

SkorikSergey added status/code-review This issue has a pull request posted for it and is awaiting code review completion by the community. kind/task Internal things, technical debt, and to-do tasks to be performed. team/che-qe labels Mar 27, 2018

SkorikSergey requested review from dmytro-ndp and Ohrimenko1988 March 27, 2018 15:19

SkorikSergey requested a review from vparfonov as a code owner March 27, 2018 15:19

dmytro-ndp reviewed Mar 27, 2018

View reviewed changes

Ohrimenko1988 reviewed Mar 28, 2018

View reviewed changes

SkorikSergey added 5 commits March 28, 2018 12:19

Merge branch 'master' of https://github.com/eclipse/che into switchFr…

aebe228

…omDashboardToIdeFrame

switchFromDashboardAndWaitProjectExplorer method renamed to switchToI…

a706e8d

…deFrameAndWaitAvailability

merged from master branch

b54efe9

added switchToNoneCurrentWindow() method to SeleniumWebDriverHelper

0cc6cf7

fixed comments

8aa1a1e

format

7f70d0c

fix factory tests

7c841ec

SkorikSergey added 2 commits April 2, 2018 11:17

merged from master

a7db76e

fixed switching from IDE to github

4d15ac5

dmytro-ndp reviewed Apr 2, 2018

View reviewed changes

SkorikSergey added 2 commits April 3, 2018 15:47

Merge branch 'master' of https://github.com/eclipse/che into switchFr…

f05270d

…omDashboardToIdeFrame

switchToIdeFrameAndWaitAvailability() method returns current window h…

3496e19

…andle

removed unused imports

33fd865

dmytro-ndp approved these changes Apr 4, 2018

View reviewed changes

SkorikSergey merged commit 219802a into master Apr 4, 2018

SkorikSergey deleted the switchFromDashboardToIdeFrame branch April 4, 2018 13:37

SkorikSergey removed the status/code-review This issue has a pull request posted for it and is awaiting code review completion by the community. label Apr 4, 2018

benoitf added this to the 6.4.0 milestone Apr 4, 2018

SkorikSergey mentioned this pull request Apr 6, 2018

Unexpected failure of selenium tests which are create workspaces from Dashboard #9100

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Selenium: add method for switching from Dashboard to IDE frame in SeleniumWebDriverHelper class #9262

Selenium: add method for switching from Dashboard to IDE frame in SeleniumWebDriverHelper class #9262

SkorikSergey commented Mar 27, 2018

dmytro-ndp Mar 27, 2018

dmytro-ndp Mar 27, 2018

SkorikSergey Apr 4, 2018

dmytro-ndp Apr 4, 2018 •

edited

Loading

dmytro-ndp Mar 27, 2018

dmytro-ndp commented Mar 27, 2018

dmytro-ndp commented Mar 27, 2018

Ohrimenko1988 Mar 28, 2018

Ohrimenko1988 Mar 28, 2018

Ohrimenko1988 Mar 28, 2018 •

edited

Loading

SkorikSergey commented Mar 30, 2018

codenvy-ci commented Mar 30, 2018

SkorikSergey commented Mar 30, 2018

codenvy-ci commented Mar 30, 2018

SkorikSergey commented Apr 1, 2018

codenvy-ci commented Apr 2, 2018

dmytro-ndp Apr 2, 2018

dmytro-ndp Apr 2, 2018 •

edited

Loading

SkorikSergey commented Apr 3, 2018

codenvy-ci commented Apr 3, 2018

		@@ -44,6 +45,7 @@
		private String gitHubUsername;

		@Inject private SeleniumWebDriver seleniumWebDriver;

		@@ -85,7 +87,7 @@ public void checkOpenFileFeatureTest() throws Exception {
		String currentWin = seleniumWebDriver.getWindowHandle();
		seleniumWebDriver.switchToNoneCurrentWindow(currentWin);

		@@ -83,7 +85,7 @@ public void createAndDeleteProjectTest() throws ExecutionException, InterruptedE
		newWorkspace.clickOnCreateButtonAndOpenInIDE();

		String dashboardWindow = seleniumWebDriver.getWindowHandle();

Selenium: add method for switching from Dashboard to IDE frame in SeleniumWebDriverHelper class #9262

Selenium: add method for switching from Dashboard to IDE frame in SeleniumWebDriverHelper class #9262

Conversation

SkorikSergey commented Mar 27, 2018

What does this PR do?

What issues does this PR fix or reference?

dmytro-ndp Mar 27, 2018

Choose a reason for hiding this comment

dmytro-ndp Mar 27, 2018

Choose a reason for hiding this comment

SkorikSergey Apr 4, 2018

Choose a reason for hiding this comment

dmytro-ndp Apr 4, 2018 • edited Loading

Choose a reason for hiding this comment

dmytro-ndp Mar 27, 2018

Choose a reason for hiding this comment

dmytro-ndp commented Mar 27, 2018

dmytro-ndp commented Mar 27, 2018

Ohrimenko1988 Mar 28, 2018

Choose a reason for hiding this comment

Ohrimenko1988 Mar 28, 2018

Choose a reason for hiding this comment

Ohrimenko1988 Mar 28, 2018 • edited Loading

Choose a reason for hiding this comment

SkorikSergey commented Mar 30, 2018

codenvy-ci commented Mar 30, 2018

SkorikSergey commented Mar 30, 2018

codenvy-ci commented Mar 30, 2018

SkorikSergey commented Apr 1, 2018

codenvy-ci commented Apr 2, 2018

dmytro-ndp Apr 2, 2018

Choose a reason for hiding this comment

dmytro-ndp Apr 2, 2018 • edited Loading

Choose a reason for hiding this comment

SkorikSergey commented Apr 3, 2018

codenvy-ci commented Apr 3, 2018

dmytro-ndp Apr 4, 2018 •

edited

Loading

Ohrimenko1988 Mar 28, 2018 •

edited

Loading

dmytro-ndp Apr 2, 2018 •

edited

Loading