Add missing service terminations #9658
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sleshchenko
added
the
kind/bug
benoitf
added
the
status/code-review
mshaposhnik
reviewed
May 10, 2018
| * Terminates {@link ProbeScheduler}. | ||
| * | ||
| * @author Sergii Leshchenko | ||
| */ |
mshaposhnik
approved these changes
May 10, 2018
skabashnyuk
approved these changes
May 10, 2018
garagatyi
approved these changes
May 10, 2018
| /** | ||
| * Terminates {@link ThreadPullLauncher}. | ||
| * | ||
| * @author Anton Korneta |
There was a problem hiding this comment.
Looks like authorship was unintentionally copied from another class
There was a problem hiding this comment.
No, it's original authorship. I separated these changes from hot_update PR.
sleshchenko
force-pushed
the
serviceTerminations
branch
from
aabe905
to
1cb5130
Compare
|
ci-test |
|
ci-test build report: |
sleshchenko
force-pushed
the
serviceTerminations
branch
from
052eb29
to
53fbced
Compare
sleshchenko
force-pushed
the
serviceTerminations
branch
from
53fbced
to
8829094
Compare
benoitf
removed
the
status/code-review
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Add service terminations for CronThreadPull and ProbeScheduller.
Move removing of the temporary workspaces from @PreDestroy phase to WorkspaceTerminationService. It is needed to make sure that temporary workspaces will be stopped before removing.
Minor change: fix logging of errors which may occur during server status updating.
What issues does this PR fix or reference?
#9415
Release Notes
N/A
Docs PR
N/A