Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Wait until Che is available when deploying it on OCP #9783

Merged
merged 1 commit into from
May 23, 2018
Merged

Conversation

dmytro-ndp
Copy link
Contributor

What does this PR do?

It fixes Che deployment on OCP scripts to wait until Che server is deployed and then is available, by default. To do that, we set WAIT_FOR_CHE=true by default and it makes --wait-che deployment script parameter as useless and we remove it as well.

What issues does this PR fix or reference?

#9761

Signed-off-by: Dmytro Nochevnov <dnochevnov@codenvy.com>
@dmytro-ndp dmytro-ndp added the kind/enhancement A feature request - must adhere to the feature request template. label May 23, 2018
@dmytro-ndp dmytro-ndp requested a review from a user May 23, 2018 13:43
@benoitf benoitf added the status/code-review This issue has a pull request posted for it and is awaiting code review completion by the community. label May 23, 2018
@ghost
Copy link

ghost commented May 23, 2018

thanks @dmytro-ndp

@dmytro-ndp
Copy link
Contributor Author

ci-test

@codenvy-ci
Copy link

ci-test build report:
Build details
Test report
selenium tests report data
docker image: eclipseche/che-server:9783
https://github.com/orgs/eclipse/teams/eclipse-che-qa please check this report.

@dmytro-ndp dmytro-ndp merged commit 6c0f87c into master May 23, 2018
@dmytro-ndp dmytro-ndp deleted the che-9761 branch May 23, 2018 20:13
@dmytro-ndp dmytro-ndp removed the status/code-review This issue has a pull request posted for it and is awaiting code review completion by the community. label May 23, 2018
@dmytro-ndp dmytro-ndp added this to the 6.6.0 milestone May 23, 2018
hbhargav pushed a commit to hbhargav/che that referenced this pull request Dec 5, 2018
Signed-off-by: Dmytro Nochevnov <dnochevnov@codenvy.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/enhancement A feature request - must adhere to the feature request template.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants