Fix browser problem rebased #146
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… proper version of webkit or xulrunner is missing)
Closed
| browser = new Browser(themeDetails, SWT.BORDER); | ||
| browser.setLayoutData(gridData); | ||
| browser.setText("<html><body></body></html>"); | ||
| if (getBrowser() != null) { |
There was a problem hiding this comment.
I'd prefer a temp here, e.g.:
Browser browser = getBrowser();
if (browser != null) {
...
|
Some of my usual nit picking, otherwise good to go! 😄 |
|
Fixed the formatting. Let me know if there is anything else you'ld like. |
|
Nope, I'm happy now 😄 Thanks again for your work and patience 😄 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a partial fix for Issue #128
The problem is that new Browser will throw an exception when it can't find a proper browser. When this happens it interupts the rest of the preferences configuration and eclipse-color-theme is not functional in this state.
This fix handles the case where the browser cannot load and allows the rest of the preferences dialog to construct minus the preview pane.
I also add the bundles to the manifest that were already used by the project to create the preferences dialog (swt and ui.forms).