Use latest tycho, allow building against kepler, luna, mars #229

Merged
merged 1 commit into from Sep 16, 2016

Projects

None yet

4 participants

@mbooth101
Contributor

This change updates the build to use the latest version of tycho and allows you to build against any of the last three major Eclipse versions.

By default, it builds against Eclipse Mars. You can build against Eclipse Luna or Kepler by passing, for example: "-Dplatform-version=kepler"

This is useful for making sure eclipse-color-theme remains compatible with all the Eclipse versions that you wish to support.

@paulvi paulvi commented on the diff Jul 7, 2015
README.md
@@ -142,6 +142,12 @@ You can generate an update site using [Maven](http://maven.apache.org/):
This will create an update site in
_com.github.eclipsecolortheme.updatesite/target/repository_.
+By default, Eclipse Color Theme will be built against the Eclipse Mars
+version of the platform. You can build against either Eclipse Luna or
+Kepler by setting the "platform-version" property, for example:
+
+ mvn clean verify -Dplatform-version=kepler
+
License
@paulvi
paulvi Jul 7, 2015 Contributor

Users just need stable plugins. Having one version that works within 4.3-4.5 is simpler.

Why to have build against Mars?

@mbooth101
mbooth101 Jul 7, 2015 Contributor

I do not suggest distributing more than version of the plugin. I merely suggest that you build/test your plugin against all versions of the platform that you intend to support. (This easily allows you to have three CI jobs to run tests against all three supported platforms.)

The point is that the platform may deprecate and remove APIs over time, but if you only ever build/test against the oldest version of the platform, you will not know that your plugin is broken until it is too late when users report it you.

The version of the platform it builds against by default is kinda irrelevant, I can change it to Kepler by default if that is what you'd prefer.

@paulvi
paulvi Jul 8, 2015 Contributor

I am not owner of this project. Build is usually personal preference.

@JMTyler
JMTyler Aug 24, 2016 edited

And now these days, it's all too clear why it's important to build/test against all supported versions of the platform.

This plugin is quite simply broken on Neon. I've installed it, and my plugin manager shows that it is installed, but navigating to Window > Preferences > General > Appearance no longer reveals a Color Theme section as it once did on previous versions. It's unusable.

I really wish this PR had been merged a year ago so we wouldn't be in this boat.

@fhd
fhd Sep 16, 2016 Member

That issue is actually a different one (see #241, will be fixed by #244).

Still, this sounds good to me, so I'll merge it soon. Sorry for the delay!

@paulvi
Contributor
paulvi commented Aug 29, 2016

@JMTyler raise separate issue with screenshot, more info

@fhd fhd merged commit 963afa3 into eclipse-color-theme:master Sep 16, 2016

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
@fhd
Member
fhd commented Sep 16, 2016

Thanks, merged! Sorry again for the delay. I wonder if we shouldn't make Neon the default target now though.

@mbooth101
Contributor

@fhd Thanks for merging. Absolutely, changing to Neon by default makes sense these days -- this was a very old PR :-)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment