Use latest tycho, allow building against kepler, luna, mars #229
Conversation
versions of eclipse-platform
| Kepler by setting the "platform-version" property, for example: | ||
|
|
||
| mvn clean verify -Dplatform-version=kepler | ||
|
|
||
| License |
There was a problem hiding this comment.
Users just need stable plugins. Having one version that works within 4.3-4.5 is simpler.
Why to have build against Mars?
There was a problem hiding this comment.
I do not suggest distributing more than version of the plugin. I merely suggest that you build/test your plugin against all versions of the platform that you intend to support. (This easily allows you to have three CI jobs to run tests against all three supported platforms.)
The point is that the platform may deprecate and remove APIs over time, but if you only ever build/test against the oldest version of the platform, you will not know that your plugin is broken until it is too late when users report it you.
The version of the platform it builds against by default is kinda irrelevant, I can change it to Kepler by default if that is what you'd prefer.
There was a problem hiding this comment.
I am not owner of this project. Build is usually personal preference.
There was a problem hiding this comment.
And now these days, it's all too clear why it's important to build/test against all supported versions of the platform.
This plugin is quite simply broken on Neon. I've installed it, and my plugin manager shows that it is installed, but navigating to Window > Preferences > General > Appearance no longer reveals a Color Theme section as it once did on previous versions. It's unusable.
I really wish this PR had been merged a year ago so we wouldn't be in this boat.
|
@JMTyler raise separate issue with screenshot, more info |
|
Thanks, merged! Sorry again for the delay. I wonder if we shouldn't make Neon the default target now though. |
|
@fhd Thanks for merging. Absolutely, changing to Neon by default makes sense these days -- this was a very old PR :-) |
This change updates the build to use the latest version of tycho and allows you to build against any of the last three major Eclipse versions.
By default, it builds against Eclipse Mars. You can build against Eclipse Luna or Kepler by passing, for example: "-Dplatform-version=kepler"
This is useful for making sure eclipse-color-theme remains compatible with all the Eclipse versions that you wish to support.