Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

In internal Ditto pub/sub, don't only filter for authorizationSubject, but also to subscribed namespaces #1894

Closed
thjaeckle opened this issue Feb 6, 2024 · 0 comments · Fixed by #1900
Milestone

Comments

@thjaeckle
Copy link
Member

Currently, when e.g. a connection in Ditto's "connectivity" service subscribes for "thing events" (modifications) to publish to e.g. a Kafka topic, it will receive all the events which the configured "authorizationContext" subject is allowed to "READ".

So it will receive all events and then apply the optionally defined RQL filter statement as well as the defined namespaces (also as a filter criteria).
The RQL filter cannot be filtered on pub/sub level, however the namespaces could be.

In the best case, the namespaces (if defined) would also be used when subscribing via Ditto pub/sub to the internal topic and a connection which e.g. is only interested in events of namespace foo would not get notified about events in namespace bar, even if it would have READ permissions for those things.

thjaeckle added a commit that referenced this issue Feb 9, 2024
…aces to topic

* this can greatly reduce the amount of message dispatched internally when subscribing only for certain namespaces
thjaeckle added a commit that referenced this issue Feb 13, 2024
…aces to topic

* this can greatly reduce the amount of message dispatched internally when subscribing only for certain namespaces
@thjaeckle thjaeckle added this to the 3.5.3 milestone Feb 13, 2024
thjaeckle added a commit that referenced this issue Feb 13, 2024
…aces to topic

* this can greatly reduce the amount of message dispatched internally when subscribing only for certain namespaces
thjaeckle added a commit that referenced this issue Feb 20, 2024
…mespaces-to-topic

#1894 optimize Ditto internal pub/sub by adding subscribed for namespaces to topic
thjaeckle added a commit that referenced this issue Feb 24, 2024
…aces to topic

* this can greatly reduce the amount of message dispatched internally when subscribing only for certain namespaces
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
1 participant