Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

#1894 optimize Ditto internal pub/sub by adding subscribed for namespaces to topic #1900

Merged
merged 2 commits into from Feb 20, 2024
Merged

#1894 optimize Ditto internal pub/sub by adding subscribed for namespaces to topic #1900

merged 2 commits into from Feb 20, 2024

Conversation

thjaeckle
Copy link
Member

  • this can greatly reduce the amount of message dispatched internally when subscribing only for certain namespaces

Resolves: #1894

@thjaeckle thjaeckle added this to the 3.5.3 milestone Feb 9, 2024
@thjaeckle thjaeckle self-assigned this Feb 9, 2024
@thjaeckle thjaeckle force-pushed the bugfix/1894-pubsub-add-namespaces-to-topic branch from 24e1701 to 281283c Compare February 13, 2024 08:15
@thjaeckle
#1894 optimize Ditto internal pub/sub by adding subscribed for namesp…
3b6362b 
…aces to topic

* this can greatly reduce the amount of message dispatched internally when subscribing only for certain namespaces
@thjaeckle thjaeckle force-pushed the bugfix/1894-pubsub-add-namespaces-to-topic branch from 281283c to 3b6362b Compare February 13, 2024 13:15
@thjaeckle
Copy link
Member Author

@alstanchev @kalinkostashki could you please have a look - and ideally run SystemTests for this optimization PR?

@kalinkostashki
Copy link
Contributor

@alstanchev @kalinkostashki could you please have a look - and ideally run SystemTests for this optimization PR?

sure @thjaeckle will do :)

kalinkostashki
kalinkostashki approved these changes Feb 20, 2024
View reviewed changes
Copy link
Contributor

@kalinkostashki kalinkostashki left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍
System and performance tests look good as well.
Please just change the unique attribute of INDEX_FOO in IndexInitializerIT in order for tests to be able to run on mongo 4.2 and mongo 6.

@thjaeckle
Copy link
Member Author

@kalinkostashki is the change the one you expected in the commit I added?

@kalinkostashki
Copy link
Contributor

@kalinkostashki is the change the one you expected in the commit I added?

yes, @thjaeckle :)
There is some logic changed in Mongo 6.0.
Where if you use a false flag and then true for unique you will not get the same exception and both keys are created.
This was observed in our jenkins and I reproduced this locally as well.
Thanks for adding it :)

@thjaeckle thjaeckle merged commit 335a26c into master Feb 20, 2024
3 checks passed
@thjaeckle thjaeckle deleted the bugfix/1894-pubsub-add-namespaces-to-topic branch February 20, 2024 14:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kalinkostashki kalinkostashki kalinkostashki approved these changes

Assignees

@thjaeckle thjaeckle

Labels
None yet
Projects
Ditto Planning
Status: Done
Milestone
3.5.3
Development

Successfully merging this pull request may close these issues.

In internal Ditto pub/sub, don't only filter for authorizationSubject, but also to subscribed namespaces
2 participants
@thjaeckle @kalinkostashki