Bugfix: connection creation timeout #692
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Sending response before trying to connect * This way the response is faster delivered and the probability of a timeout is reduced. Signed-off-by: Yannic Klem <yannic.klem@bosch.io>
Signed-off-by: Dominik Guggemos <dominik.guggemos@bosch.io>
Signed-off-by: Dominik Guggemos <dominik.guggemos@bosch.io>
Signed-off-by: Dominik Guggemos <dominik.guggemos@bosch.io>
Signed-off-by: Dominik Guggemos <dominik.guggemos@bosch.io>
Signed-off-by: Dominik Guggemos <dominik.guggemos@bosch.io>
connection * Since in this special case it is possible that the EnableConnectionLogs command is emitted a second time by the UPDATE_SUBSCRIPTIONS step. Signed-off-by: Yannic Klem <yannic.klem@bosch.io>
Signed-off-by: Yannic Klem <yannic.klem@bosch.io>
* Since we get the created response before the connection is established, we won't get notified anymore when the connection is established. As workaround we wait for any subscriptions which happen in the UPDATE_SUBSCRIPTIONS action of ConnectionPersistenceActor Signed-off-by: Yannic Klem <yannic.klem@bosch.io>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was an issue where sometimes the creation of a connection entity failed with a timeout just because the establishing of the actual connection took too much time.
This PR reorders the actions that are performed when creating a connection, so a successful response will be sent as soon as the connection could be created.
The establishing of the actual connection happens after this and is not part of the success response.