Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bugfix: connection creation timeout #692

Merged
merged 9 commits into from Jun 17, 2020
Merged

Bugfix: connection creation timeout #692

merged 9 commits into from Jun 17, 2020

Commits on May 11, 2020

  1. Reorder actions for creating a connection 

    * Sending response before trying to connect
* This way the response is faster delivered and the probability of a timeout
  is reduced.

Signed-off-by: Yannic Klem <yannic.klem@bosch.io>
    @Yannic92
    Yannic92 committed May 11, 2020
    Copy the full SHA
    aedba55 View commit details
    Browse the repository at this point in the history

Commits on May 14, 2020

  1. Merge branch 'master' into bugfix/connection-creation-timeout 

    Signed-off-by: Dominik Guggemos <dominik.guggemos@bosch.io>
    @dguggemos
    dguggemos committed May 14, 2020
    Copy the full SHA
    9544add View commit details
    Browse the repository at this point in the history

Commits on May 15, 2020

  1. fix unit tests by waiting until connection actor subscribed for signals 

    Signed-off-by: Dominik Guggemos <dominik.guggemos@bosch.io>
    @dguggemos
    dguggemos committed May 15, 2020
    Copy the full SHA
    6e5f954 View commit details
    Browse the repository at this point in the history

Commits on May 25, 2020

  1. Merge branch 'master' into bugfix/connection-creation-timeout 

    Signed-off-by: Dominik Guggemos <dominik.guggemos@bosch.io>
    @dguggemos
    dguggemos committed May 25, 2020
    Copy the full SHA
    ee1a692 View commit details
    Browse the repository at this point in the history

Commits on Jun 5, 2020

  1. include state of internal pubsub into liveStatus of connection 

    Signed-off-by: Dominik Guggemos <dominik.guggemos@bosch.io>
    @dguggemos
    dguggemos committed Jun 5, 2020
    Copy the full SHA
    d1154da View commit details
    Browse the repository at this point in the history

  2. Merge branch 'master' into bugfix/connection-creation-timeout 

    Signed-off-by: Dominik Guggemos <dominik.guggemos@bosch.io>
    @dguggemos
    dguggemos committed Jun 5, 2020
    Copy the full SHA
    1293db2 View commit details
    Browse the repository at this point in the history

Commits on Jun 16, 2020

  1. Adjust test for re-enabling of connection logs after modification of a 

    connection

* Since in this special case it is possible that the EnableConnectionLogs
  command is emitted a second time by the UPDATE_SUBSCRIPTIONS step.

Signed-off-by: Yannic Klem <yannic.klem@bosch.io>
    @Yannic92
    Yannic92 committed Jun 16, 2020
    Copy the full SHA
    66ab478 View commit details
    Browse the repository at this point in the history

  2. remove unused import 

    Signed-off-by: Yannic Klem <yannic.klem@bosch.io>
    @Yannic92
    Yannic92 committed Jun 16, 2020
    Copy the full SHA
    6082e44 View commit details
    Browse the repository at this point in the history

  3. Wait until connection is established in unit tests 

    * Since we get the created response before the connection is established,
  we won't get notified anymore when the connection is established. As
  workaround we wait for any subscriptions which happen in the UPDATE_SUBSCRIPTIONS
  action of ConnectionPersistenceActor

Signed-off-by: Yannic Klem <yannic.klem@bosch.io>
    @Yannic92
    Yannic92 committed Jun 16, 2020
    Copy the full SHA
    5f058d8 View commit details
    Browse the repository at this point in the history