Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[#903] provide OpenAPI documentation for /cloudevents on API 2 #911

Merged
merged 2 commits into from
Dec 10, 2020

Conversation

thjaeckle
Copy link
Member

Did not add explicitly for API 1 as this one already is deprecated and not so well integrated in Ditto's OpenAPI building based on several source files.

… API 2

Signed-off-by: Thomas Jaeckle <thomas.jaeckle@bosch.io>
@thjaeckle thjaeckle added this to the 1.5.0 milestone Dec 10, 2020
@yufei-cai yufei-cai self-requested a review December 10, 2020 11:21
Copy link
Contributor

@yufei-cai yufei-cai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

* missing specversion lead to 500 error
* exception texts were improved

Signed-off-by: Thomas Jaeckle <thomas.jaeckle@bosch.io>
@thjaeckle thjaeckle merged commit 7f5d2f7 into eclipse-ditto:master Dec 10, 2020
@thjaeckle thjaeckle deleted the doc/cloudevents-openapi branch December 10, 2020 12:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants