Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Store eCAL timestamps in us and ROS timestamps in ns #67

Merged
merged 1 commit into from
Aug 3, 2023
Merged

Store eCAL timestamps in us and ROS timestamps in ns #67

merged 1 commit into from
Aug 3, 2023

Conversation

JWhitleyWork
Copy link
Contributor

Closes #66.

@JWhitleyWork
Store eCAL timestamps in us and ROS timestamps in ns.
e72153c 
Signed-off-by: Joshua Whitley <josh@electrifiedautonomy.com>
KerstinKeller
KerstinKeller approved these changes Aug 2, 2023
View reviewed changes
Copy link

@KerstinKeller KerstinKeller left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 I think this makes a lot of sense.

@JWhitleyWork
Copy link
Contributor Author

@FlorianReimold Are you able to merge this?

@FlorianReimold
Copy link
Member

Sure 😊

@FlorianReimold FlorianReimold merged commit a1349c5 into eclipse-ecal:master Aug 3, 2023
5 checks passed
@JWhitleyWork JWhitleyWork deleted the fix-timestamp-unit branch August 3, 2023 11:21
@JWhitleyWork
Copy link
Contributor Author

Sure 😊

Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@KerstinKeller KerstinKeller KerstinKeller approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

send_timestamp and receive_timestamp are not comparable
3 participants
@JWhitleyWork @FlorianReimold @KerstinKeller