Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bugfix: change time when loaders are cleared #1498

Conversation

paullatzelsperger
Copy link
Member

@paullatzelsperger paullatzelsperger commented Jun 20, 2022

What this PR changes/adds

To avoid inconsistent loader storages, the time, when they are cleared was changed.
Now, all loaders are cleared just before the ExecutionPlan is scheduled.

Why it does that

Do avoid inconsistent loader storages.

Further notes

  • the pre-executionHook could be used for other tasks as well.
  • theoretically we could add a post-executionHook as well, but that was not needed as of now.

Linked Issue(s)

Closes #1495

Checklist

  • added appropriate tests?
  • performed checkstyle check locally?
  • added/updated copyright headers?
  • documented public classes/methods?
  • added/updated relevant documentation?
  • added relevant details to the changelog? (skip with label no-changelog)
  • formatted title correctly? (take a look at the CONTRIBUTING and styleguide for details)

@paullatzelsperger paullatzelsperger added the bug Something isn't working label Jun 20, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Federated Catalog is broken due to FCC clean-up
2 participants