Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cosmos DB: update missing field behavior #1514

Conversation

algattik
Copy link
Contributor

What this PR changes/adds

Fix failing Cosmos DB integration test CosmosContractNegotiationStoreIntegrationTest.

Why it does that

Cosmos DB behavior recently changed as documented: Queries with ORDER BY will return all items, including items where the property in the ORDER BY clause isn't defined.

Further notes

Also fixed logic for failing org.eclipse.dataspaceconnector.cosmos.policy.store.CosmosPolicyDefinitionStoreIntegrationTest#verify_readWriteFindAll

Linked Issue(s)

Closes #1512

Checklist

  • added appropriate tests?
  • performed checkstyle check locally?
  • added/updated copyright headers?
  • documented public classes/methods?
  • added/updated relevant documentation?
  • added relevant details to the changelog? (skip with label no-changelog)
  • formatted title correctly? (take a look at the CONTRIBUTING and styleguide for details)

@algattik algattik marked this pull request as ready for review June 22, 2022 07:53
@paullatzelsperger paullatzelsperger merged commit 0af7f64 into eclipse-edc:main Jun 22, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Change in Cosmos DB handling of sorting with missing field
2 participants