-
Notifications
You must be signed in to change notification settings - Fork 224
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: improve pull request workflows #1737
chore: improve pull request workflows #1737
Conversation
1870c06
to
2472cfb
Compare
Codecov Report
@@ Coverage Diff @@
## main #1737 +/- ##
=============================================
- Coverage 67.34% 10.55% -56.79%
- Complexity 0 475 +475
=============================================
Files 785 785
Lines 16859 16858 -1
Branches 1061 1061
=============================================
- Hits 11353 1779 -9574
- Misses 5050 14995 +9945
+ Partials 456 84 -372
Continue to review full report at Codecov.
|
26bc38f
to
8021696
Compare
- uses: actions/checkout@v3 | ||
- uses: agilepathway/label-checker@v1.0.113 | ||
with: | ||
any_of: api,bug,build,dependencies,documentation,enhancement,ids,java,no-changelog,policy,refactoring |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I would propose to choose the labels based on which categories we want to see in the changelog.
e.g. currently now there are only Bugfixes (bug), Documentation (documentation) and New Features & Improvements (*).
I would keep bug
, documentation
, enhancement
(that could be used for new features
), no-changelog
.
maybe also api
, dependencies
and refactoring
(that could be added as categories in the changelog
task configuration)
but I would avoid the others (build
, ids
, java
, policy
).
Makes sense?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yes.. the problem is that there is no action that allows wildcards, so e.g. changes to the pipeline would need the build
label as no PRs with 0 labels are allowed. Maybe just skip ids
, java
, policy
as this is too specific? The other ones kind of match the conventional commits prefixes.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I would suggest to take a look at adding further categories to the changelog later.. first step is to have labels.
8021696
to
24efb38
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
good for me
* chore: improve restriction of PR title (define prefixes) * chore: add check for labels
What this PR changes/adds
Add new regex that is more restrictive. PR titles have to match the conventional commit prefixes. Add label checker.
Why it does that
Improve PR quality. Label check was suggested in #1728.
Further notes
...
Linked Issue(s)
Relates #1719
Checklist
no-changelog
)