-
Notifications
You must be signed in to change notification settings - Fork 229
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: Fix usage of default @Provider methods in IdentityDidCoreExtension #1792
Merged
bscholtes1A
merged 2 commits into
eclipse-edc:main
from
bscholtes1A:fix-default-provider-identity-did-core-extension
Aug 8, 2022
Merged
fix: Fix usage of default @Provider methods in IdentityDidCoreExtension #1792
bscholtes1A
merged 2 commits into
eclipse-edc:main
from
bscholtes1A:fix-default-provider-identity-did-core-extension
Aug 8, 2022
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bscholtes1A
requested review from
paullatzelsperger and
juliapampus
as code owners
August 5, 2022 13:46
bscholtes1A
changed the title
Fix usage of default @Provider methods in IdentityDidCoreExtension
did: Fix usage of default @Provider methods in IdentityDidCoreExtension
Aug 5, 2022
bscholtes1A
changed the title
did: Fix usage of default @Provider methods in IdentityDidCoreExtension
fix: Fix usage of default @Provider methods in IdentityDidCoreExtension
Aug 5, 2022
7 tasks
bscholtes1A
force-pushed
the
fix-default-provider-identity-did-core-extension
branch
from
August 5, 2022 14:55
e0502e6
to
503dfe8
Compare
7 tasks
marcgs
reviewed
Aug 8, 2022
try { | ||
return (ECKey) ECKey.parseFromPEMEncodedObjects(encoded); | ||
return (ECKey) JWK.parseFromPEMEncodedObjects(encoded); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
How is this related to this change?
algattik
reviewed
Aug 8, 2022
...-core/src/main/java/org/eclipse/dataspaceconnector/iam/did/DidResolverRegistryExtension.java
Outdated
Show resolved
Hide resolved
Codecov Report
@@ Coverage Diff @@
## main #1792 +/- ##
==========================================
- Coverage 67.82% 67.80% -0.02%
==========================================
Files 795 800 +5
Lines 16899 16979 +80
Branches 1078 1080 +2
==========================================
+ Hits 11461 11512 +51
- Misses 4969 4997 +28
- Partials 469 470 +1
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
paullatzelsperger
approved these changes
Aug 8, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR changes/adds
Make some
@Provider
methods non-default inIdentityDidCoreExtension
as this is causing non-deterministic dependency injection inIdentityHub
project.Why it does that
Default
@Provider
methods depending on injected services might be invoked while these services are not yet initialized.Checklist
no-changelog
)