feat(Event Framework): add intermediate superclass for Asset Events #1815
Conversation
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
spi/core-spi/src/main/java/org/eclipse/dataspaceconnector/spi/event/asset/AssetCreated.java
Fixed
Show fixed
Hide fixed
spi/core-spi/src/main/java/org/eclipse/dataspaceconnector/spi/event/asset/AssetDeleted.java
Fixed
Show fixed
Hide fixed
Codecov Report
@@ Coverage Diff @@
## main #1815 +/- ##
============================================
- Coverage 62.54% 62.53% -0.01%
- Complexity 0 3182 +3182
============================================
Files 781 782 +1
Lines 16592 16592
Branches 1079 1079
============================================
- Hits 10377 10376 -1
- Misses 5767 5768 +1
Partials 448 448
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
|
|
||
| import java.util.Objects; | ||
|
|
||
| /** | ||
| * Describe an Asset deletion, after this has emitted, the Asset represented by the id won't be available anymore. | ||
| */ | ||
| public class AssetDeleted extends Event<AssetDeleted.Payload> { | ||
| public class AssetDeleted extends AssetEvent { |
There was a problem hiding this comment.
| public class AssetDeleted extends AssetEvent { | |
| public class AssetDeleted extends Event<AssetDeleted.Payload> { |
I think the AssetDeleted should be related to its own payload, currently it's the same for both the events, but this could change in any moment
There was a problem hiding this comment.
If i change it like the way you suggest their is no superclass again.
But you are right i messed up the Relation. I want sth. like EventPayload <- AssetPayload <- AssetCreatedPayload/AssetDeleted Payload. I need to change it this way.
There was a problem hiding this comment.
Looking it from another perspective seems like the hierarchy is more related to the payload than to the event class itself...
Maybe the only class we need to introduce is a AssetEventPayload that contains the assetId and that it could be used to filter out events.
|
|
||
| private AssetDeleted() { | ||
| } | ||
|
|
||
| public static class Builder extends Event.Builder<AssetDeleted, Payload, Builder> { | ||
| public static class Builder extends Event.Builder<AssetDeleted, AssetEvent.Payload, Builder> { |
There was a problem hiding this comment.
Same as above, and at a this point I would move the builder logic that permits to add an assetId on the AssetEvent superclass
janpmeyer
force-pushed
the
feature/event-framework-add-Asset-Event
branch
2 times, most recently
from
20fe780
to
8800ccb
Compare
janpmeyer
force-pushed
the
feature/event-framework-add-Asset-Event
branch
from
8800ccb
to
b4f6055
Compare
|
The hierarchy is now binded on the Payload classes. |
...core-spi/src/main/java/org/eclipse/dataspaceconnector/spi/event/asset/AssetEventPayload.java
Outdated
Show resolved
Hide resolved
|
Test, who fails has no connection to Eventsystem and touched Files. |
What this PR changes/adds
Add a 'intermediate' superclass for the Event Classes
AssetCreatedandAssetDeleted.Why it does that
Improve the work with the Event Framework and give the possibility to filter Events on a bigger group of events
Linked Issue(s)
Closes #1813
Checklist
no-changelog)