Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: use @Setting and @SettingContext #2097

Conversation

paullatzelsperger
Copy link
Member

@paullatzelsperger paullatzelsperger commented Oct 14, 2022

What this PR changes/adds

Issue eclipse-edc/GradlePlugins#19 deprecates @EdcSetting and @EdcSettingContext in favor of @Setting and @SettingContext, which are now used everywhere.

Why it does that

To keep the naming consistent with the other runtime metamodel annotations.

Further notes

Linked Issue(s)

Closes eclipse-edc/GradlePlugins#19

Checklist

  • added appropriate tests?
  • performed checkstyle check locally?
  • added/updated copyright headers?
  • documented public classes/methods?
  • added/updated relevant documentation?
  • assigned appropriate label? (exclude from changelog with label no-changelog)
  • formatted title correctly? (take a look at the CONTRIBUTING and styleguide for details)

@github-actions github-actions bot added this to In progress in Connector Oct 14, 2022
@paullatzelsperger paullatzelsperger added the refactoring Cleaning up code and dependencies label Oct 14, 2022
@paullatzelsperger paullatzelsperger temporarily deployed to Azure-dev October 14, 2022 10:14 Inactive
@paullatzelsperger paullatzelsperger force-pushed the refactor/19_use_Setting_insteadof_EdcSetting branch from 8fac660 to 91e0729 Compare October 14, 2022 14:59
@paullatzelsperger paullatzelsperger temporarily deployed to Azure-dev October 14, 2022 14:59 Inactive
@paullatzelsperger paullatzelsperger temporarily deployed to Azure-dev October 14, 2022 15:12 Inactive
@paullatzelsperger paullatzelsperger temporarily deployed to Azure-dev October 16, 2022 09:07 Inactive
@codecov-commenter
Copy link

codecov-commenter commented Oct 16, 2022

Codecov Report

Base: 64.74% // Head: 64.74% // No change to project coverage 👍

Coverage data is based on head (605e521) compared to base (6623720).
Patch has no changes to coverable lines.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #2097   +/-   ##
=======================================
  Coverage   64.74%   64.74%           
=======================================
  Files         792      792           
  Lines       16881    16881           
  Branches     1090     1090           
=======================================
  Hits        10929    10929           
  Misses       5497     5497           
  Partials      455      455           
Impacted Files Coverage Δ
...ceconnector/core/CoreDefaultServicesExtension.java 68.42% <ø> (ø)
...dataspaceconnector/core/CoreServicesExtension.java 93.93% <ø> (ø)
...aspaceconnector/core/base/OkHttpClientFactory.java 92.85% <ø> (ø)
...ceconnector/contract/ContractServiceExtension.java 95.77% <ø> (ø)
...connector/transfer/core/CoreTransferExtension.java 0.00% <ø> (ø)
...taplane/framework/DataPlaneFrameworkExtension.java 80.95% <ø> (ø)
...pi/configuration/IdsApiConfigurationExtension.java 88.23% <ø> (ø)
...aceconnector/ids/core/IdsCoreServiceExtension.java 0.00% <ø> (ø)
...tor/ids/core/service/ConnectorServiceSettings.java 1.17% <ø> (ø)
...aspaceconnector/ids/core/util/ConnectorIdUtil.java 0.00% <ø> (ø)
... and 33 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@paullatzelsperger paullatzelsperger temporarily deployed to Azure-dev October 17, 2022 04:43 Inactive
Connector automation moved this from In progress to Review in progress Oct 17, 2022
@paullatzelsperger paullatzelsperger force-pushed the refactor/19_use_Setting_insteadof_EdcSetting branch from 605e521 to 68f4a69 Compare October 20, 2022 09:09
@paullatzelsperger paullatzelsperger temporarily deployed to Azure-dev October 20, 2022 09:09 Inactive
@paullatzelsperger paullatzelsperger merged commit 93f53eb into eclipse-edc:main Oct 20, 2022
Connector automation moved this from Review in progress to Done Oct 20, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
refactoring Cleaning up code and dependencies
Projects
No open projects
Connector
  
Done
Development

Successfully merging this pull request may close these issues.

Rename EdcSetting to Setting
5 participants