-
Notifications
You must be signed in to change notification settings - Fork 214
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor: use @Setting
and @SettingContext
#2097
Merged
paullatzelsperger
merged 1 commit into
eclipse-edc:main
from
paullatzelsperger:refactor/19_use_Setting_insteadof_EdcSetting
Oct 20, 2022
Merged
refactor: use @Setting
and @SettingContext
#2097
paullatzelsperger
merged 1 commit into
eclipse-edc:main
from
paullatzelsperger:refactor/19_use_Setting_insteadof_EdcSetting
Oct 20, 2022
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
docs/developer/decision-records/2022-08-04-documentation-automation/README.md
Show resolved
Hide resolved
8fac660
to
91e0729
Compare
Codecov ReportBase: 64.74% // Head: 64.74% // No change to project coverage 👍
Additional details and impacted files@@ Coverage Diff @@
## main #2097 +/- ##
=======================================
Coverage 64.74% 64.74%
=======================================
Files 792 792
Lines 16881 16881
Branches 1090 1090
=======================================
Hits 10929 10929
Misses 5497 5497
Partials 455 455
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
ronjaquensel
approved these changes
Oct 17, 2022
ndr-brt
approved these changes
Oct 18, 2022
bscholtes1A
approved these changes
Oct 18, 2022
605e521
to
68f4a69
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR changes/adds
Issue eclipse-edc/GradlePlugins#19 deprecates
@EdcSetting
and@EdcSettingContext
in favor of@Setting
and@SettingContext
, which are now used everywhere.Why it does that
To keep the naming consistent with the other runtime metamodel annotations.
Further notes
this PR should be merged AFTER this one refactor: deprecate EdcSetting, add Setting GradlePlugins#27Actions will fail until refactor: deprecate EdcSetting, add Setting GradlePlugins#27 is merged and publishedmodules.md
file and its generation, as it sometimes caused problems. If needed, we can make it a separate gradle task.Linked Issue(s)
Closes eclipse-edc/GradlePlugins#19
Checklist
no-changelog
)