Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: deprecate EdcSetting, add Setting #27

Conversation

paullatzelsperger
Copy link
Member

@paullatzelsperger paullatzelsperger commented Oct 14, 2022

What this PR changes/adds

Deprecates the @EdcSetting and @EdcSettingContext annotations, and introduces a new @Setting and @SettingContext annotations, both of which are exact copies of the old thing.

Why it does that

To keep consistent with the naming of all other metamodel annotations.

Further notes

We need to do the deprecation and removing in two separate steps, otherwise there could be a time where builds in downstream projects fail, until the make the switch as well.

Linked Issue(s)

Closes #19

Checklist

  • added appropriate tests?
  • performed checkstyle check locally?
  • added/updated copyright headers?
  • documented public classes/methods?
  • added/updated relevant documentation?
  • assigned appropriate label? (exclude from changelog with label no-changelog)
  • formatted title correctly? (take a look at the CONTRIBUTING and styleguide for details)

@paullatzelsperger paullatzelsperger merged commit 0b52ef2 into eclipse-edc:main Oct 14, 2022
@paullatzelsperger paullatzelsperger deleted the refactor/19_deprecate_EdcSetting branch October 14, 2022 14:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Rename EdcSetting to Setting
2 participants