feat: make CredentialService URL configurable #3635
Conversation
paullatzelsperger
requested review from
bscholtes1A,
jimmarino,
ndr-brt and
wolf4ood
paullatzelsperger
force-pushed
the
feat/iatp_credentialservice_url_configurable
branch
from
36caf8e
to
c84cda7
Compare
paullatzelsperger
force-pushed
the
feat/iatp_credentialservice_url_configurable
branch
from
c84cda7
to
fe0769e
Compare
Codecov ReportAttention:
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## main #3635 +/- ##
==========================================
- Coverage 71.77% 71.76% -0.01%
==========================================
Files 914 914
Lines 18276 18278 +2
Branches 1036 1036
==========================================
+ Hits 13117 13118 +1
- Misses 4707 4708 +1
Partials 452 452 ☔ View full report in Codecov by Sentry. |
| public CredentialServiceClient createClient(ServiceExtensionContext context) { | ||
| return new DefaultCredentialServiceClient(httpClient, Json.createBuilderFactory(Map.of()), | ||
| typeManager.getMapper(JSON_LD), typeTransformerRegistry, jsonLd, context.getMonitor(), | ||
| context.getConfig().getString(CREDENTIALSERVICE_URL_PROPERTY)); |
There was a problem hiding this comment.
@paullatzelsperger are we sure jsonLd will be injected before this method is invoked? (as it is a isDefault = true)
There was a problem hiding this comment.
mmh, interesting point. Theoretically, it could happen, if some extension injects the CredentialServiceClient before the JsonLd service gets created. The safe way would probably be to remove the isDefault=true attribute, which also makes replacing the Default...Client harder to replace.
What this PR changes/adds
This PR adds a configuration value for the URL of the credentialservice, which is a mandatory config parameter
when using IATP
Why it does that
Being able to forward credential requests
Further notes
DefaultCredentialServiceClientto the defaults extension, to make it easily replaceableCredentialServiceClientone would simply have to provide another implementation analogous to theDefaultCredentialServiceClientLinked Issue(s)
Closes # <-- insert Issue number if one exists
Please be sure to take a look at the contributing guidelines and our etiquette for pull requests.