Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: compilation #3699

Merged
merged 2 commits into from Dec 11, 2023
Merged

fix: compilation #3699

merged 2 commits into from Dec 11, 2023

Conversation

ndr-brt
Copy link
Member

@ndr-brt ndr-brt commented Dec 11, 2023

What this PR changes/adds

Fix compilation errors caused by eclipse-edc/GradlePlugins#200

Why it does that

Briefly state why the change was necessary.

Further notes

List other areas of code that have changed but are not necessarily linked to the main feature. This could be method
signature changes, package declarations, bugs that were encountered and were fixed inline, etc.

Linked Issue(s)

Closes # <-- insert Issue number if one exists

Please be sure to take a look at the contributing guidelines and our etiquette for pull requests.

@ndr-brt ndr-brt added the build Anything related to the CI/CD Pipeline on Github Actions label Dec 11, 2023
@codecov-commenter
Copy link

Codecov Report

Attention: 7 lines in your changes are missing coverage. Please review.

Comparison is base (c72fc66) 71.72% compared to head (cd1ac68) 71.71%.
Report is 1 commits behind head on main.

Files Patch % Lines
...or/dataplane/api/DataPlaneControlApiExtension.java 0.00% 4 Missing ⚠️
.../api/controller/DataPlaneControlApiController.java 66.66% 2 Missing ⚠️
...tor/dataplane/api/DataPlanePublicApiExtension.java 0.00% 1 Missing ⚠️

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3699      +/-   ##
==========================================
- Coverage   71.72%   71.71%   -0.02%     
==========================================
  Files         919      919              
  Lines       18447    18450       +3     
  Branches     1034     1034              
==========================================
  Hits        13232    13232              
- Misses       4756     4759       +3     
  Partials      459      459              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ndr-brt ndr-brt merged commit 2295148 into eclipse-edc:main Dec 11, 2023
17 checks passed
@ndr-brt ndr-brt deleted the fix-compilation branch December 11, 2023 15:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
build Anything related to the CI/CD Pipeline on Github Actions
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants