Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: avoid dependency automatic injection #200

Merged
merged 2 commits into from
Dec 11, 2023

Conversation

ndr-brt
Copy link
Member

@ndr-brt ndr-brt commented Dec 11, 2023

What this PR changes/adds

Avoids automatic production dependency injection.

Why it does that

shrink the dependency tree

Further notes

  • I noticed that the convention in fact always used the version hardcoded in the class, so I added a gradle plugin that takes care of generating a Versions interface that contains the version of the test dependencies contained in this project catalog (that is under dependabot control). So the version of these dependencies is kept updated automatically ( unfortunately I wasn't able to put that code in the buildSrc source code, I got errors, I think as it is is good enough, but I'm open to suggestions for further improvements)

Linked Issue(s)

Closes #197

Please be sure to take a look at the contributing guidelines and our etiquette for pull requests.

Copy link

github-actions bot commented Dec 11, 2023

Test Results

40 tests  ±0   40 ✔️ ±0   16s ⏱️ ±0s
10 suites ±0     0 💤 ±0 
10 files   ±0     0 ±0 

Results for commit 403584d. ± Comparison against base commit 3cf93ea.

♻️ This comment has been updated with latest results.

@ndr-brt ndr-brt force-pushed the 197-avoid-dependency-automatic-injection branch from c718c37 to 403584d Compare December 11, 2023 13:33
Copy link
Member

@paullatzelsperger paullatzelsperger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🔥

@ndr-brt ndr-brt merged commit 188d2d6 into main Dec 11, 2023
17 checks passed
@ndr-brt ndr-brt deleted the 197-avoid-dependency-automatic-injection branch December 11, 2023 13:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Avoid metamodel automatic dependency
2 participants