feat: DataFlowManager and DataFlowController refactoring #3917
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wolf4ood
added
refactoring
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
| */ | ||
| @NotNull | ||
| StatusResult<DataFlowResponse> initiateFlow(TransferProcess transferProcess, Policy policy); | ||
| StatusResult<DataFlowResponse> start(TransferProcess transferProcess, Policy policy); |
Check notice
Code scanning / CodeQL
Useless parameter Note
wolf4ood
force-pushed
the
feat/3899_data_flow_controller_refactor
branch
2 times, most recently
from
35e2f37
to
0425d8d
Compare
wolf4ood
force-pushed
the
feat/3899_data_flow_controller_refactor
branch
3 times, most recently
from
d83e438
to
e1e06ea
Compare
wolf4ood
force-pushed
the
feat/3899_data_flow_controller_refactor
branch
from
e1e06ea
to
4aa29de
Compare
| @Override | ||
| public Builder self() { | ||
| return this; | ||
| } | ||
|
|
||
| public DataPlaneManagerImpl build() { |
Check notice
Code scanning / CodeQL
Missing Override annotation Note
wolf4ood
requested review from
bscholtes1A,
jimmarino and
paullatzelsperger
as code owners
paullatzelsperger
approved these changes
Feb 26, 2024
jimmarino
approved these changes
Feb 26, 2024
ndr-brt
approved these changes
Feb 26, 2024
wolf4ood
added
the
breaking-change
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR changes/adds
DataFlowManager,DataFlowControllerandDataPlaneClientmethods for staring a new data flow were refactor according the term used in the data plane signaling spec.Additionally now the
DataFlowResponsemay contain thedataPlaneIdselected for the transfer that will be storedinto the
TransferProcesswhen transitioning to the started state. This will allow to punctually deliver subsequent message to the right data plane. If nodataPlaneIdis not present the behaviour is the same as before.Additionally the
trackedflag has been removed in the dataplane.The
suspendis not introduced in this PR since it will first need support in theDataPlaneand in the DSP protocol implementation #3350Why it does that
data plane signaling
Closes #3899
Please be sure to take a look at the contributing guidelines and our etiquette for pull requests.