-
Notifications
You must be signed in to change notification settings - Fork 226
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: DataFlowManager and DataFlowController refactoring #3917
Merged
wolf4ood
merged 5 commits into
eclipse-edc:main
from
wolf4ood:feat/3899_data_flow_controller_refactor
Feb 26, 2024
Merged
feat: DataFlowManager and DataFlowController refactoring #3917
wolf4ood
merged 5 commits into
eclipse-edc:main
from
wolf4ood:feat/3899_data_flow_controller_refactor
Feb 26, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wolf4ood
added
refactoring
Cleaning up code and dependencies
enhancement
New feature or request
labels
Feb 23, 2024
wolf4ood
force-pushed
the
feat/3899_data_flow_controller_refactor
branch
2 times, most recently
from
February 23, 2024 18:00
35e2f37
to
0425d8d
Compare
wolf4ood
force-pushed
the
feat/3899_data_flow_controller_refactor
branch
3 times, most recently
from
February 23, 2024 18:19
d83e438
to
e1e06ea
Compare
wolf4ood
force-pushed
the
feat/3899_data_flow_controller_refactor
branch
from
February 23, 2024 18:23
e1e06ea
to
4aa29de
Compare
@Override | ||
public Builder self() { | ||
return this; | ||
} | ||
|
||
public DataPlaneManagerImpl build() { |
Check notice
Code scanning / CodeQL
Missing Override annotation Note
This method overrides ; it is advisable to add an Override annotation.
Builder<DataFlow,DataPlaneStore,DataPlaneManagerImpl,Builder>.build
Error loading related location
Loading
wolf4ood
requested review from
bscholtes1A,
jimmarino and
paullatzelsperger
as code owners
February 26, 2024 12:39
paullatzelsperger
approved these changes
Feb 26, 2024
jimmarino
approved these changes
Feb 26, 2024
ndr-brt
approved these changes
Feb 26, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'd add the breaking change
label as there are changes in the SQL schema
wolf4ood
added
the
breaking-change
Will require manual intervention for version update
label
Feb 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
breaking-change
Will require manual intervention for version update
dpf
Feature related to the Data Plane Framework
enhancement
New feature or request
refactoring
Cleaning up code and dependencies
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR changes/adds
DataFlowManager
,DataFlowController
andDataPlaneClient
methods for staring a new data flow were refactor according the term used in the data plane signaling spec.Additionally now the
DataFlowResponse
may contain thedataPlaneId
selected for the transfer that will be storedinto the
TransferProcess
when transitioning to the started state. This will allow to punctually deliver subsequent message to the right data plane. If nodataPlaneId
is not present the behaviour is the same as before.Additionally the
tracked
flag has been removed in the dataplane.The
suspend
is not introduced in this PR since it will first need support in theDataPlane
and in the DSP protocol implementation #3350Why it does that
data plane signaling
Closes #3899
Please be sure to take a look at the contributing guidelines and our etiquette for pull requests.