Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: move key-related classes into a separate SPI and Lib module #4038

Merged
merged 4 commits into from
Mar 22, 2024

Conversation

jimmarino
Copy link
Contributor

What this PR changes/adds

This PR moves key-related interfaces and classes into their own SPI and Lib modules so that they are isolated from the core connector implementation.

Linked Issue(s)

Part of #4028

@jimmarino jimmarino added the refactoring Cleaning up code and dependencies label Mar 22, 2024
@jimmarino jimmarino requested a review from wolf4ood March 22, 2024 14:12
@codecov-commenter
Copy link

codecov-commenter commented Mar 22, 2024

Codecov Report

Attention: Patch coverage is 20.00000% with 4 lines in your changes are missing coverage. Please review.

Project coverage is 74.03%. Comparing base (7f20ba5) to head (2a98e38).
Report is 161 commits behind head on main.

Files Patch % Lines
...ava/org/eclipse/edc/keys/keyparsers/JwkParser.java 20.00% 4 Missing ⚠️

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #4038      +/-   ##
==========================================
+ Coverage   71.74%   74.03%   +2.28%     
==========================================
  Files         919      989      +70     
  Lines       18457    20053    +1596     
  Branches     1037     1126      +89     
==========================================
+ Hits        13242    14846    +1604     
+ Misses       4756     4726      -30     
- Partials      459      481      +22     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@jimmarino jimmarino merged commit b6e26c1 into eclipse-edc:main Mar 22, 2024
16 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
refactoring Cleaning up code and dependencies
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants