Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: separate identity-trust-spi #4080

Conversation

paullatzelsperger
Copy link
Member

What this PR changes/adds

Splits off all verifiable credential related classes from identity-trust-spi into a verifiable-credentials-spi module.

Why it does that

So that Verifiable Credentials become usable even without IATP

Further notes

List other areas of code that have changed but are not necessarily linked to the main feature. This could be method
signature changes, package declarations, bugs that were encountered and were fixed inline, etc.

Linked Issue(s)

Closes # <-- insert Issue number if one exists

Please be sure to take a look at the contributing guidelines and our etiquette for pull requests.

@paullatzelsperger paullatzelsperger added the refactoring Cleaning up code and dependencies label Apr 3, 2024
Copy link
Contributor

@jimmarino jimmarino left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Only 80 files changed?

@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 74.57%. Comparing base (7f20ba5) to head (a263604).
Report is 193 commits behind head on main.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #4080      +/-   ##
==========================================
+ Coverage   71.74%   74.57%   +2.82%     
==========================================
  Files         919      975      +56     
  Lines       18457    19967    +1510     
  Branches     1037     1120      +83     
==========================================
+ Hits        13242    14890    +1648     
+ Misses       4756     4594     -162     
- Partials      459      483      +24     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@paullatzelsperger paullatzelsperger merged commit 4e706af into eclipse-edc:main Apr 3, 2024
18 checks passed
@paullatzelsperger paullatzelsperger deleted the chore/separate_identity-trust-spi branch April 3, 2024 13:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
refactoring Cleaning up code and dependencies
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants